| Message ID | 1464267431.5939.81.camel@edumazet-glaptop3.roam.corp.google.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, May 26, 2016 at 3:57 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > On Thu, 2016-05-26 at 12:44 +0300, Tariq Toukan wrote: >> Hi Eric, >> >> > mlx4 has various bugs in its ndo_get_stats() and related functions. >> > This patch series address the obvious issues. >> > Remaining ones will be discussed later. >> > >> Thanks for the fixes. >> I see they were already applied. >> I reviewed them all and replied to patch 4/4, the rest look good to me. >> Please CC me as the maintainer of mlx4_en on future patches. > > If you are mlx4_en maintainer, please submit an official patch so that > non Mellanox employees can get this information using the normal way ? Eric, sure, we were on a transition period and Tariq was not fully familiar with that practice, I'd like to make sure the move is finalized internally and then we'll send the patch.. On a somehow related note, Dave, Eric's patches were sent after our Wed working hours ended and accepted before our Thu working hours started.. could we get a better chance to review driver patches before acceptance? I know there were times where we've screwed up and things didn't get fast attention, but we're working to improve so... get us a chance [1]? Or. [1] when it comes to weekends, the IL WW ends on Thu when the US WW has almost two full days to go (Thu, Fri), so here the response latency might be bigger, but Sun-Thu we should be responding on the same day.
On Thu, 2016-05-26 at 18:19 +0300, Or Gerlitz wrote: > On Thu, May 26, 2016 at 3:57 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > > On Thu, 2016-05-26 at 12:44 +0300, Tariq Toukan wrote: > >> Hi Eric, > >> > >> > mlx4 has various bugs in its ndo_get_stats() and related functions. > >> > This patch series address the obvious issues. > >> > Remaining ones will be discussed later. > >> > > >> Thanks for the fixes. > >> I see they were already applied. > >> I reviewed them all and replied to patch 4/4, the rest look good to me. > >> Please CC me as the maintainer of mlx4_en on future patches. > > > > If you are mlx4_en maintainer, please submit an official patch so that > > non Mellanox employees can get this information using the normal way ? > > Eric, sure, we were on a transition period and Tariq was not fully > familiar with that practice, > I'd like to make sure the move is finalized internally and then we'll > send the patch.. Sure ! Please note I gave a polite answer, I am sorry if you felt any hidden intent from my side. I did CC the official mlx4_en maintainer on this patch series, by simply looking at MAINTAINERS file.
From: Or Gerlitz <gerlitz.or@gmail.com> Date: Thu, 26 May 2016 18:19:34 +0300 > Eric, sure, we were on a transition period and Tariq was not fully > familiar with that practice, > I'd like to make sure the move is finalized internally and then we'll > send the patch.. > > On a somehow related note, Dave, Eric's patches were sent after our > Wed working hours ended and accepted before our Thu working hours > started.. could we get a better chance to review driver patches > before acceptance? I know there were times where we've screwed up > and things didn't get fast attention, but we're working to improve > so... get us a chance [1]? If Eric's patches are clearly correct, I will apply them if I want to. Sorry.
diff --git a/MAINTAINERS b/MAINTAINERS index 8d397157981c..4a35221e4819 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7250,6 +7250,7 @@ F: drivers/scsi/megaraid/ MELLANOX ETHERNET DRIVER (mlx4_en) M: Eugenia Emantayev <eugenia@mellanox.com> +M: Tariq Toukan <tariqt@mellanox.com> L: netdev@vger.kernel.org S: Supported W: http://www.mellanox.com