Message ID | alpine.LFD.2.20.1605241716520.14369@Device-040570 |
---|---|
State | Not Applicable, archived |
Headers | show |
On Tue, May 24, 2016 at 05:20:28PM -0400, Robert P. J. Day wrote: > > Reported-by: Adam J Allison <adamj.allison@gmail.com> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> This should go thru the omap/TI tree. Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/25/2016 12:20 AM, Robert P. J. Day wrote: Thanks! It shows that in the Linux driver we are not using the mperr interrupt at all... Thank you agian for spotting it, Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Reported-by: Adam J Allison <adamj.allison@gmail.com> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > --- > > diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt > index 079b42a..18090e7 100644 > --- a/Documentation/devicetree/bindings/dma/ti-edma.txt > +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt > @@ -15,7 +15,7 @@ Required properties: > - reg: Memory map of eDMA CC > - reg-names: "edma3_cc" > - interrupts: Interrupt lines for CCINT, MPERR and CCERRINT. > -- interrupt-names: "edma3_ccint", "emda3_mperr" and "edma3_ccerrint" > +- interrupt-names: "edma3_ccint", "edma3_mperr" and "edma3_ccerrint" > - ti,tptcs: List of TPTCs associated with the eDMA in the following form: > <&tptc_phandle TC_priority_number>. The highest priority is 0. > > @@ -48,7 +48,7 @@ edma: edma@49000000 { > reg = <0x49000000 0x10000>; > reg-names = "edma3_cc"; > interrupts = <12 13 14>; > - interrupt-names = "edma3_ccint", "emda3_mperr", "edma3_ccerrint"; > + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; > dma-requests = <64>; > #dma-cells = <2>; > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 52be48b..03521ea 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -187,7 +187,7 @@ > reg = <0x49000000 0x10000>; > reg-names = "edma3_cc"; > interrupts = <12 13 14>; > - interrupt-names = "edma3_ccint", "emda3_mperr", > + interrupt-names = "edma3_ccint", "edma3_mperr", > "edma3_ccerrint"; > dma-requests = <64>; > #dma-cells = <2>; > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 12fcde4..27557b0 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -199,7 +199,7 @@ > interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "edma3_ccint", "emda3_mperr", > + interrupt-names = "edma3_ccint", "edma3_mperr", > "edma3_ccerrint"; > dma-requests = <64>; > #dma-cells = <2>; > diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi > index d4537dc..a6e0aebc 100644 > --- a/arch/arm/boot/dts/dm814x.dtsi > +++ b/arch/arm/boot/dts/dm814x.dtsi > @@ -448,7 +448,7 @@ > reg = <0x49000000 0x10000>; > reg-names = "edma3_cc"; > interrupts = <12 13 14>; > - interrupt-names = "edma3_ccint", "emda3_mperr", > + interrupt-names = "edma3_ccint", "edma3_mperr", > "edma3_ccerrint"; > dma-requests = <64>; > #dma-cells = <2>; > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index e007401..95c8424 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -341,7 +341,7 @@ > interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "edma3_ccint", "emda3_mperr", > + interrupt-names = "edma3_ccint", "edma3_mperr", > "edma3_ccerrint"; > dma-requests = <64>; > #dma-cells = <2>; > > rday >
* Peter Ujfalusi <peter.ujfalusi@ti.com> [160525 12:42]: > On 05/25/2016 12:20 AM, Robert P. J. Day wrote: > > Thanks! It shows that in the Linux driver we are not using the mperr interrupt > at all... > > Thank you agian for spotting it, > > Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Applying into omap-for-v4.8/dt thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt index 079b42a..18090e7 100644 --- a/Documentation/devicetree/bindings/dma/ti-edma.txt +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt @@ -15,7 +15,7 @@ Required properties: - reg: Memory map of eDMA CC - reg-names: "edma3_cc" - interrupts: Interrupt lines for CCINT, MPERR and CCERRINT. -- interrupt-names: "edma3_ccint", "emda3_mperr" and "edma3_ccerrint" +- interrupt-names: "edma3_ccint", "edma3_mperr" and "edma3_ccerrint" - ti,tptcs: List of TPTCs associated with the eDMA in the following form: <&tptc_phandle TC_priority_number>. The highest priority is 0. @@ -48,7 +48,7 @@ edma: edma@49000000 { reg = <0x49000000 0x10000>; reg-names = "edma3_cc"; interrupts = <12 13 14>; - interrupt-names = "edma3_ccint", "emda3_mperr", "edma3_ccerrint"; + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; dma-requests = <64>; #dma-cells = <2>; diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 52be48b..03521ea 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -187,7 +187,7 @@ reg = <0x49000000 0x10000>; reg-names = "edma3_cc"; interrupts = <12 13 14>; - interrupt-names = "edma3_ccint", "emda3_mperr", + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; dma-requests = <64>; #dma-cells = <2>; diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 12fcde4..27557b0 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -199,7 +199,7 @@ interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "edma3_ccint", "emda3_mperr", + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; dma-requests = <64>; #dma-cells = <2>; diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi index d4537dc..a6e0aebc 100644 --- a/arch/arm/boot/dts/dm814x.dtsi +++ b/arch/arm/boot/dts/dm814x.dtsi @@ -448,7 +448,7 @@ reg = <0x49000000 0x10000>; reg-names = "edma3_cc"; interrupts = <12 13 14>; - interrupt-names = "edma3_ccint", "emda3_mperr", + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; dma-requests = <64>; #dma-cells = <2>; diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index e007401..95c8424 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -341,7 +341,7 @@ interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "edma3_ccint", "emda3_mperr", + interrupt-names = "edma3_ccint", "edma3_mperr", "edma3_ccerrint"; dma-requests = <64>; #dma-cells = <2>;
Reported-by: Adam J Allison <adamj.allison@gmail.com> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- rday