Patchwork mtd/pcmciamtd: remove dead code

login
register
mail settings
Submitter Dan Carpenter
Date Aug. 24, 2010, 11:56 a.m.
Message ID <20100824115627.GD29330@bicker>
Download mbox | patch
Permalink /patch/62567/
State Accepted
Commit a41ccf5a3e22c3dc1e7be134afdaa97e1aed01e2
Headers show

Comments

Dan Carpenter - Aug. 24, 2010, 11:56 a.m.
This code isn't reachable.  I looked through the git history and it
hasn't been reachable for years.  Someone removed the label to silence
gcc's unused label warning but these few lines accidentally got left
behind.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Dominik Brodowski - Aug. 29, 2010, 7:15 p.m.
On Tue, Aug 24, 2010 at 01:56:27PM +0200, Dan Carpenter wrote:
> This code isn't reachable.  I looked through the git history and it
> hasn't been reachable for years.  Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>

Thanks,
	Dominik
Artem Bityutskiy - Aug. 30, 2010, 1:17 p.m.
On Tue, 2010-08-24 at 13:56 +0200, Dan Carpenter wrote:
> This code isn't reachable.  I looked through the git history and it
> hasn't been reachable for years.  Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Pushed to l2-mtd-2.6.git / master, thanks.

Patch

diff --git a/drivers/mtd/maps/pcmciamtd.c b/drivers/mtd/maps/pcmciamtd.c
index e9ca5ba..86c7468 100644
--- a/drivers/mtd/maps/pcmciamtd.c
+++ b/drivers/mtd/maps/pcmciamtd.c
@@ -654,10 +654,6 @@  static int pcmciamtd_config(struct pcmcia_device *link)
 	}
 	dev_info(&dev->p_dev->dev, "mtd%d: %s\n", mtd->index, mtd->name);
 	return 0;
-
-	dev_err(&dev->p_dev->dev, "CS Error, exiting\n");
-	pcmciamtd_release(link);
-	return -ENODEV;
 }