osmo-pcu[master]: rlc.h: remove duplicated define RLC_EGPRS_SNS
diff mbox

Message ID gerrit.1464094082531.Ibb718ba9be21831c56c5949e730fab5acd691d7c@gerrit.osmocom.org
State New
Headers show

Commit Message

gerrit-no-reply@lists.osmocom.org May 24, 2016, 12:48 p.m. UTC
Review at  https://gerrit.osmocom.org/107

rlc.h: remove duplicated define RLC_EGPRS_SNS

Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c
---
M src/rlc.h
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/107/1

Comments

gerrit-no-reply@lists.osmocom.org May 24, 2016, 1:54 p.m. UTC | #1
Patch Set 1: Code-Review+2
gerrit-no-reply@lists.osmocom.org May 24, 2016, 2:17 p.m. UTC | #2
Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/107/1//COMMIT_MSG
Commit Message:

Line 7: rlc.h: remove duplicated define RLC_EGPRS_SNS
Can you explain where it is duplicated? What is the compiler warning you get?
gerrit-no-reply@lists.osmocom.org May 24, 2016, 3:50 p.m. UTC | #3
Patch Set 2:

(1 comment)

@Holger: I'vn't looked at compiler warnings. Just found it by accident ;)

https://gerrit.osmocom.org/#/c/107/1/src/rlc.h
File src/rlc.h:

Line 33
here
gerrit-no-reply@lists.osmocom.org May 25, 2016, 7:44 p.m. UTC | #4
Patch Set 2: Code-Review+2

Patch
diff mbox

diff --git a/src/rlc.h b/src/rlc.h
index 8f75588..03659da 100644
--- a/src/rlc.h
+++ b/src/rlc.h
@@ -27,7 +27,6 @@ 
 
 #define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */
 #define RLC_GPRS_WS  64 /* max window size */
-#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */
 #define RLC_EGPRS_MIN_WS 64 /* min window size */
 #define RLC_EGPRS_MAX_WS 1024 /* min window size */
 #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */