osmo-pcu[master]: tbf_ul: use correct size for chunk_size
diff mbox

Message ID gerrit.1464094082530.If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf@gerrit.osmocom.org
State New
Headers show

Commit Message

gerrit-no-reply@lists.osmocom.org May 24, 2016, 12:48 p.m. UTC
Review at  https://gerrit.osmocom.org/105

tbf_ul: use correct size for chunk_size

The size of the hole array in bytes was used instead of the size of elements.

Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf
---
M src/tbf_ul.cpp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/105/1

Comments

gerrit-no-reply@lists.osmocom.org May 24, 2016, 1:20 p.m. UTC | #1
Patch Set 1: Code-Review-1
gerrit-no-reply@lists.osmocom.org May 24, 2016, 2:30 p.m. UTC | #2
Patch Set 2: Code-Review+2

Great find! Looks like parse_extensions_gprs uses chunk_sizes as number of array elements.

Patch
diff mbox

diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 9e763f4..5178875 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -60,7 +60,7 @@ 
 	LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len);
 
 	num_frames = Decoding::rlc_data_from_ul_data(
-		rdbi, cs, data, &(frames[0]), sizeof(frames),
+		rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frame),
 		&dummy_tlli);
 
 	/* create LLC frames */