Patchwork [2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus

login
register
mail settings
Submitter Ken CC
Date Aug. 24, 2010, 6:48 a.m.
Message ID <20100824064841.GA11495@kt>
Download mbox | patch
Permalink /patch/62555/
State New
Headers show

Comments

Ken CC - Aug. 24, 2010, 6:48 a.m.
assert(devfn < PCIBUS_MAX_DEVICES)

Signed-off-by: Ken CC <ken.ccao@gmail.com>
---
 hw/pci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/pci.c b/hw/pci.c
index 02019a1..1e804da 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -747,6 +747,7 @@  static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
                                          PCIConfigWriteFunc *config_write,
                                          bool is_bridge)
 {
+    assert(devfn < PCIBUS_MAX_DEVICES);
     if (devfn < 0) {
         for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices);
             devfn += PCI_FUNC_MAX) {