| Message ID | e2165535dff3cfc30e82b5e3b4b4ccf9860ebf9f.1464049539.git.vilhelm.gray@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote: > With the introduction of the ISA_BUS_API Kconfig option, ISA-style > drivers may be built for X86_64 architectures. This patch changes the > ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC > driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is > expected to. > > Cc: Hartmut Knaack <knaack.h@gmx.de> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: Jonathan Cameron <jic23@kernel.org> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > drivers/iio/dac/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > index e63b957..315442f 100644 > --- a/drivers/iio/dac/Kconfig > +++ b/drivers/iio/dac/Kconfig > @@ -247,7 +247,7 @@ config MCP4922 > > config STX104 > tristate "Apex Embedded Systems STX104 DAC driver" > - depends on X86 && ISA > + depends on ISA_BUS_API Assuming the dropped dependency on X86 is intentional: Reviewed-by: Guenter Roeck <linux@roeck-us.net> > help > Say yes here to build support for the 2-channel DAC on the Apex > Embedded Systems STX104 integrated analog PC/104 card. The base port > -- > 2.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 27, 2016 at 11:20:57AM -0700, Guenter Roeck wrote: >On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote: >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style >> drivers may be built for X86_64 architectures. This patch changes the >> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC >> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is >> expected to. >> >> Cc: Hartmut Knaack <knaack.h@gmx.de> >> Cc: Lars-Peter Clausen <lars@metafoo.de> >> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> >> Cc: Jonathan Cameron <jic23@kernel.org> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> >> --- >> drivers/iio/dac/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig >> index e63b957..315442f 100644 >> --- a/drivers/iio/dac/Kconfig >> +++ b/drivers/iio/dac/Kconfig >> @@ -247,7 +247,7 @@ config MCP4922 >> >> config STX104 >> tristate "Apex Embedded Systems STX104 DAC driver" >> - depends on X86 && ISA >> + depends on ISA_BUS_API > >Assuming the dropped dependency on X86 is intentional: > >Reviewed-by: Guenter Roeck <linux@roeck-us.net> Thanks for the review Guenter: losing the X86 dependency was not intentional; it looks like I forgot to adjust this when I made ISA_BUS_API available to all architectures. I'll submit version 5 with the explicit X86 dependency back in place for CONFIG_STX104 and CONFIG_EBC_C384_WDT. William Breathitt Gray -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 27, 2016 at 03:54:00PM -0400, William Breathitt Gray wrote: > On Fri, May 27, 2016 at 11:20:57AM -0700, Guenter Roeck wrote: > >On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote: > >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style > >> drivers may be built for X86_64 architectures. This patch changes the > >> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC > >> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is > >> expected to. > >> > >> Cc: Hartmut Knaack <knaack.h@gmx.de> > >> Cc: Lars-Peter Clausen <lars@metafoo.de> > >> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > >> Cc: Jonathan Cameron <jic23@kernel.org> > >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >> --- > >> drivers/iio/dac/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > >> index e63b957..315442f 100644 > >> --- a/drivers/iio/dac/Kconfig > >> +++ b/drivers/iio/dac/Kconfig > >> @@ -247,7 +247,7 @@ config MCP4922 > >> > >> config STX104 > >> tristate "Apex Embedded Systems STX104 DAC driver" > >> - depends on X86 && ISA > >> + depends on ISA_BUS_API > > > >Assuming the dropped dependency on X86 is intentional: > > > >Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Thanks for the review Guenter: losing the X86 dependency was not > intentional; it looks like I forgot to adjust this when I made > ISA_BUS_API available to all architectures. I'll submit version 5 with > the explicit X86 dependency back in place for CONFIG_STX104 and > CONFIG_EBC_C384_WDT. > Ok. Feel free to keep my Reviewed-by: tag unless you make further changes. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index e63b957..315442f 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -247,7 +247,7 @@ config MCP4922 config STX104 tristate "Apex Embedded Systems STX104 DAC driver" - depends on X86 && ISA + depends on ISA_BUS_API help Say yes here to build support for the 2-channel DAC on the Apex Embedded Systems STX104 integrated analog PC/104 card. The base port
With the introduction of the ISA_BUS_API Kconfig option, ISA-style drivers may be built for X86_64 architectures. This patch changes the ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is expected to. Cc: Hartmut Knaack <knaack.h@gmx.de> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: Jonathan Cameron <jic23@kernel.org> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/iio/dac/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)