Patchwork Require nonpic effective target for gcc.target/i386/volatile-2.c

login
register
mail settings
Submitter Jack Howarth
Date Aug. 24, 2010, 3:29 a.m.
Message ID <20100824032954.GA27113@bromo.med.uc.edu>
Download mbox | patch
Permalink /patch/62538/
State New
Headers show

Comments

Jack Howarth - Aug. 24, 2010, 3:29 a.m.
The attached patch eliminates the failures of...

FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_0(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_1(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_2(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_3(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_4(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_5(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t]obj_5(\\(%rip\\))?,
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_6(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_7(\\(%rip\\))?
FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_8(\\(%rip\\))?

on *86-apple-darwin* at -m32 due the -fPIC default on darwin. Tested on x86-64-apple-darwin10
at -m32. Okay for gcc trunk?
          Jack


2010-08-24  Jack Howarth  <howarth@bromo.med.uc.edu>

	* testsuite/gcc.target/i386/volatile-2.c: Require nonpic effective target.
Jack Howarth - Aug. 24, 2010, 4:18 a.m.
On Mon, Aug 23, 2010 at 11:29:54PM -0400, Jack Howarth wrote:
>    The attached patch eliminates the failures of...
> 
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_0(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_1(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_2(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_3(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_4(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_5(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t]obj_5(\\(%rip\\))?,
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_6(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_7(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_8(\\(%rip\\))?
> 
> on *86-apple-darwin* at -m32 due the -fPIC default on darwin. Tested on x86-64-apple-darwin10
> at -m32. Okay for gcc trunk?
>           Jack
> 
> 
> 2010-08-24  Jack Howarth  <howarth@bromo.med.uc.edu>
> 
> 	* testsuite/gcc.target/i386/volatile-2.c: Require nonpic effective target.
> 
> 
> Index: gcc/testsuite/gcc.target/i386/volatile-2.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/volatile-2.c	(revision 163490)
> +++ gcc/testsuite/gcc.target/i386/volatile-2.c	(working copy)
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target nonpic } */
>  /* { dg-options "-O2" } */
>  
>  /* Check volatiles are written, read or not re-read consistently */

  One minor correction. These failures occur at both -m32 and -m64 with -fPIC
on intel darwin.
          Jack
Richard Guenther - Aug. 24, 2010, 9:40 a.m.
On Tue, Aug 24, 2010 at 5:29 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>   The attached patch eliminates the failures of...
>
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_0(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_1(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_2(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_3(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_4(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_5(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t]obj_5(\\(%rip\\))?,
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_6(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_7(\\(%rip\\))?
> FAIL: gcc.target/i386/volatile-2.c scan-assembler movl[ \t][^,]+, obj_8(\\(%rip\\))?
>
> on *86-apple-darwin* at -m32 due the -fPIC default on darwin. Tested on x86-64-apple-darwin10
> at -m32. Okay for gcc trunk?

Ok.

Richard.

>          Jack
>
>
> 2010-08-24  Jack Howarth  <howarth@bromo.med.uc.edu>
>
>        * testsuite/gcc.target/i386/volatile-2.c: Require nonpic effective target.
>
>
> Index: gcc/testsuite/gcc.target/i386/volatile-2.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/volatile-2.c  (revision 163490)
> +++ gcc/testsuite/gcc.target/i386/volatile-2.c  (working copy)
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target nonpic } */
>  /* { dg-options "-O2" } */
>
>  /* Check volatiles are written, read or not re-read consistently */
>

Patch

Index: gcc/testsuite/gcc.target/i386/volatile-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/volatile-2.c	(revision 163490)
+++ gcc/testsuite/gcc.target/i386/volatile-2.c	(working copy)
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O2" } */
 
 /* Check volatiles are written, read or not re-read consistently */