Patchwork [vect] Ask for review and approving the patch about vect and loongson

login
register
mail settings
Submitter Mingjie Xing
Date Aug. 24, 2010, 3:24 a.m.
Message ID <AANLkTim29GzyiLWjkN6d=4BfKGyXQ9XLX7Z8i+88xecZ@mail.gmail.com>
Download mbox | patch
Permalink /patch/62533/
State New
Headers show

Comments

Mingjie Xing - Aug. 24, 2010, 3:24 a.m.
2010/8/24 Richard Sandiford <rdsandiford@googlemail.com>:
> Richard Guenther <richard.guenther@gmail.com> writes:
>> On Sat, Aug 21, 2010 at 10:29 AM, Richard Sandiford
>> <rdsandiford@googlemail.com> wrote:
>>> Uros Bizjak <ubizjak@gmail.com> writes:
>>>> On Tue, Aug 17, 2010 at 11:49 AM, Mingjie Xing <mingjie.xing@gmail.com> wrote:
>>>>> Updated. See the attachment.
>>>>
>>>> Perhaps we should extend the comment a bit:
>>>>
>>>> +# Check whether the vectorizer tests are supported by the target and append
>>>> +# additional target-dependent compile flags to DEFAULT_VECTFLAGS.  Also
>>>> +# set dg-do-what-default to either compile or run, depending on target
>>>> +# capabilities.  Return 1 if vectorizer tests are supported by
>>>> target, 0 otherwise.
>>>>
>>>>> Is it OK?
>>>>
>>>> Looks OK to me.  Richi, can you please formally approve the patch?
>>>
>>> Seems like this might have got stuck.  Mingjie's original patch is
>>> certainly a step forward in its own right, so Mingjie, please feel free
>>> to commit your original MIPS-specific gcc.dg/vect/vect.exp patch if you
>>> don't get an approval for this one in the next couple of days.  Please
>>> update the other two vect.exps in the same way, at the same time.
>>
>> As we do not have an (active) testsuite maintainer right now please treat
>> target specific changes as covered by your target maintainership.
>
> TBH, I'd been doing that even before Janis left. ;-)  And that's why
> I'd approved Mingjie's original patch when he posted it, before Uros
> pointed out that there were two other copies to update.
>
> I wasn't sure the patch to unify the three copies qualified as a
> MIPS-specific change though.  It changes the behaviour for ARM.
>
> Richard
>

Hi all, to make this easier, I now just modify the MIPS-specific
parts. The patch has been checked in. Thanks again.

Mingjie

2010-08-24  Mingjie Xing  <mingjie.xing@gmail.com>

        * gcc.dg/vect/vect.exp: Check loongson targets
        * g++.dg/vect/vect.exp: Likewise
        * gfortran.dg/vect/vect.exp: Likewise

Patch

Index: gcc.dg/vect/vect.exp
===================================================================
--- gcc.dg/vect/vect.exp	(revision 163494)
+++ gcc.dg/vect/vect.exp	(working copy)
@@ -74,9 +74,12 @@  if  [istarget "powerpc-*paired*"]  {
 	set dg-do-what-default compile
     }
 } elseif { [istarget "mips*-*-*"]
-	   && [check_effective_target_mpaired_single]
+	   && ([check_effective_target_mpaired_single]
+		|| [check_effective_target_mips_loongson])
 	   && [check_effective_target_nomips16] } {
-    lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    if { [check_effective_target_mpaired_single] } {
+	lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    }
     set dg-do-what-default run
 } elseif [istarget "sparc*-*-*"] {
     lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"
Index: g++.dg/vect/vect.exp
===================================================================
--- g++.dg/vect/vect.exp	(revision 163494)
+++ g++.dg/vect/vect.exp	(working copy)
@@ -82,9 +82,12 @@  if  [istarget "powerpc-*paired*"]  {
 	set dg-do-what-default compile
     }
 } elseif { [istarget "mips*-*-*"]
-	   && [check_effective_target_mpaired_single]
+	   && ([check_effective_target_mpaired_single]
+		|| [check_effective_target_mips_loongson])
 	   && [check_effective_target_nomips16] } {
-    lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    if { [check_effective_target_mpaired_single] } {
+	lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    }
     set dg-do-what-default run
 } elseif [istarget "sparc*-*-*"] {
     lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"
Index: gfortran.dg/vect/vect.exp
===================================================================
--- gfortran.dg/vect/vect.exp	(revision 163494)
+++ gfortran.dg/vect/vect.exp	(working copy)
@@ -75,9 +75,12 @@  if  [istarget "powerpc-*paired*"]  {
 	set dg-do-what-default compile
     }
 } elseif { [istarget "mips*-*-*"]
-	   && [check_effective_target_mpaired_single]
+	   && ([check_effective_target_mpaired_single]
+		|| [check_effective_target_mips_loongson])
 	   && [check_effective_target_nomips16] } {
-    lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    if { [check_effective_target_mpaired_single] } {
+	lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    }
     set dg-do-what-default run
 } elseif [istarget "sparc*-*-*"] {
     lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"