Message ID | 1225288566-18457-1-git-send-email-vapier@gentoo.org |
---|---|
State | Accepted, archived |
Delegated to: | Jeff Garzik |
Headers | show |
On Wed, 29 Oct 2008, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger <vapier@gentoo.org> Acked-by: Nicolas Pitre <nico@cam.org> > --- > drivers/net/smc91x.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c > index c70870e..6f9895d 100644 > --- a/drivers/net/smc91x.c > +++ b/drivers/net/smc91x.c > @@ -2060,7 +2060,6 @@ static int smc_request_attrib(struct platform_device *pdev, > struct net_device *ndev) > { > struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); > - struct smc_local *lp = netdev_priv(ndev); > > if (!res) > return 0; > @@ -2075,7 +2074,6 @@ static void smc_release_attrib(struct platform_device *pdev, > struct net_device *ndev) > { > struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); > - struct smc_local *lp = netdev_priv(ndev); > > if (res) > release_mem_region(res->start, ATTRIB_SIZE); > -- > 1.6.0.2 > Nicolas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Mike Frysinger wrote: > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > drivers/net/smc91x.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c > index c70870e..6f9895d 100644 > --- a/drivers/net/smc91x.c > +++ b/drivers/net/smc91x.c > @@ -2060,7 +2060,6 @@ static int smc_request_attrib(struct platform_device *pdev, > struct net_device *ndev) > { > struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); > - struct smc_local *lp = netdev_priv(ndev); > > if (!res) > return 0; > @@ -2075,7 +2074,6 @@ static void smc_release_attrib(struct platform_device *pdev, > struct net_device *ndev) > { > struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); > - struct smc_local *lp = netdev_priv(ndev); > applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 29 Oct 2008 09:56:06 -0400, Mike Frysinger <vapier@gentoo.org> wrote: > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > drivers/net/smc91x.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c > index c70870e..6f9895d 100644 > --- a/drivers/net/smc91x.c > +++ b/drivers/net/smc91x.c > @@ -2060,7 +2060,6 @@ static int smc_request_attrib(struct platform_device *pdev, > struct net_device *ndev) > { > struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); > - struct smc_local *lp = netdev_priv(ndev); > > if (!res) > return 0; The local variable 'lp' is actually used on some platforms (via SMC_IO_SHIFT). Please revert this change and do another way ("unused" marker or something) to fix the warnings. --- Atsushi Nemoto -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index c70870e..6f9895d 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -2060,7 +2060,6 @@ static int smc_request_attrib(struct platform_device *pdev, struct net_device *ndev) { struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); - struct smc_local *lp = netdev_priv(ndev); if (!res) return 0; @@ -2075,7 +2074,6 @@ static void smc_release_attrib(struct platform_device *pdev, struct net_device *ndev) { struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib"); - struct smc_local *lp = netdev_priv(ndev); if (res) release_mem_region(res->start, ATTRIB_SIZE);
Signed-off-by: Mike Frysinger <vapier@gentoo.org> --- drivers/net/smc91x.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)