| Message ID | CAH10aOiTKmRPEFYts8jjWLcGKw0RdPQbeVWn9xHo_C60kNEbWw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
Test build shows no warnings
On Mon, May 23, 2016 at 08:55:19PM +0800, Jesse Sung wrote: > BugLink: https://launchpad.net/bugs/1528910 > BugLink: https://launchpad.net/bugs/1512997 > BugLink: https://launchpad.net/bugs/1512999 > > V2: Fix Warning in "UBUNTU: SAUCE: mwifiex: add iw vendor command support" Applied to Xenial. Thanks Jesse! -Kamal > > The first eight patches are Marvell wireless driver update for FCC regulation. > Most of them are in mainline 4.5 except the "add iw vendor command support" one, > which is not accepted by upstream[1]. I'm sending it as an Ubuntu sauce before > we can have a solution. > > The last two patches are for WiFi and Bluetooth LEDs on Dell's Edge Gateway. > LEDs are connected to GPIOs on Marvell Wifi/BT module, so the code will > check if it is run on Edge Gateway before it toggles the LEDs, in case these > GPIOs are configured to do something else on other platforms. These two patches > are already in vivid kernel for a while. > > > [1] https://marc.info/?l=linux-wireless&m=144982455414246&w=2 > > ================================================================ > The following changes since commit f18d7a47ebd9086e6aa36b823cdce8665efb0c53: > > UBUNTU: Ubuntu-4.4.0-22.40 (2016-05-12 13:42:19 -0700) > > are available in the git repository at: > > https://git.launchpad.net/~wenchien/+git/xenial marvell-v2 > > for you to fetch changes up to 5ea2e59a3e9f376021a3957ea27f4218fb2b7977: > > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > (2016-05-23 18:30:16 +0800) > > ---------------------------------------------------------------- > Amitkumar Karwar (7): > mwifiex: parse adhoc start/join result > mwifiex: handle start AP error paths correctly > mwifiex: set regulatory info from EEPROM > mwifiex: don't follow AP if country code received from EEPROM > mwifiex: correction in region code to country mapping > mwifiex: update region_code_index array > mwifiex: use world for unidentified region code > > Wen-chien Jesse Sung (2): > UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the > device status > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > > chunfan chen (1): > UBUNTU: SAUCE: mwifiex: add iw vendor command support > > drivers/bluetooth/btusb.c | 92 ++++++++++++++++++++++++++++-- > drivers/net/wireless/mwifiex/Makefile | 1 + > drivers/net/wireless/mwifiex/cfg80211.c | 20 +++++-- > drivers/net/wireless/mwifiex/cfp.c | 6 +- > drivers/net/wireless/mwifiex/cmdevt.c | 4 +- > drivers/net/wireless/mwifiex/fw.h | 30 +++++++++- > drivers/net/wireless/mwifiex/ie.c | 2 +- > drivers/net/wireless/mwifiex/join.c | 20 ++++--- > drivers/net/wireless/mwifiex/main.c | 5 +- > drivers/net/wireless/mwifiex/main.h | 12 +++- > drivers/net/wireless/mwifiex/pcie.c | 6 ++ > drivers/net/wireless/mwifiex/sta_cmd.c | 50 ++++++++++++++-- > drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 + > drivers/net/wireless/mwifiex/sta_ioctl.c | 23 +++++++- > drivers/net/wireless/mwifiex/uap_cmd.c | 6 +- > drivers/net/wireless/mwifiex/vendor.c | 83 +++++++++++++++++++++++++++ > drivers/net/wireless/mwifiex/vendor.h | 28 +++++++++ > 17 files changed, 353 insertions(+), 37 deletions(-) > create mode 100644 drivers/net/wireless/mwifiex/vendor.c > create mode 100644 drivers/net/wireless/mwifiex/vendor.h > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Mon, May 23, 2016 at 06:38:45AM -0700, Kamal Mostafa wrote: > On Mon, May 23, 2016 at 08:55:19PM +0800, Jesse Sung wrote: > > BugLink: https://launchpad.net/bugs/1528910 > > BugLink: https://launchpad.net/bugs/1512997 > > BugLink: https://launchpad.net/bugs/1512999 > > > > V2: Fix Warning in "UBUNTU: SAUCE: mwifiex: add iw vendor command support" > > Applied to Xenial. Thanks Jesse! > Hi Jesse- You marked one of the three with 'verification-failed-xenial': https://launchpad.net/bugs/1512999 I have verified that your patch: 8b6d64a UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules is applied in the -proposed kernel (Ubuntu-4.4.0-25.44). Were you (and are still) able to demonstrate the problem as fixed by that patch in your own Xenial test build? Whats up here? -Kamal > > > > > The first eight patches are Marvell wireless driver update for FCC regulation. > > Most of them are in mainline 4.5 except the "add iw vendor command support" one, > > which is not accepted by upstream[1]. I'm sending it as an Ubuntu sauce before > > we can have a solution. > > > > The last two patches are for WiFi and Bluetooth LEDs on Dell's Edge Gateway. > > LEDs are connected to GPIOs on Marvell Wifi/BT module, so the code will > > check if it is run on Edge Gateway before it toggles the LEDs, in case these > > GPIOs are configured to do something else on other platforms. These two patches > > are already in vivid kernel for a while. > > > > > > [1] https://marc.info/?l=linux-wireless&m=144982455414246&w=2 > > > > ================================================================ > > The following changes since commit f18d7a47ebd9086e6aa36b823cdce8665efb0c53: > > > > UBUNTU: Ubuntu-4.4.0-22.40 (2016-05-12 13:42:19 -0700) > > > > are available in the git repository at: > > > > https://git.launchpad.net/~wenchien/+git/xenial marvell-v2 > > > > for you to fetch changes up to 5ea2e59a3e9f376021a3957ea27f4218fb2b7977: > > > > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > > (2016-05-23 18:30:16 +0800) > > > > ---------------------------------------------------------------- > > Amitkumar Karwar (7): > > mwifiex: parse adhoc start/join result > > mwifiex: handle start AP error paths correctly > > mwifiex: set regulatory info from EEPROM > > mwifiex: don't follow AP if country code received from EEPROM > > mwifiex: correction in region code to country mapping > > mwifiex: update region_code_index array > > mwifiex: use world for unidentified region code > > > > Wen-chien Jesse Sung (2): > > UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the > > device status > > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > > > > chunfan chen (1): > > UBUNTU: SAUCE: mwifiex: add iw vendor command support > > > > drivers/bluetooth/btusb.c | 92 ++++++++++++++++++++++++++++-- > > drivers/net/wireless/mwifiex/Makefile | 1 + > > drivers/net/wireless/mwifiex/cfg80211.c | 20 +++++-- > > drivers/net/wireless/mwifiex/cfp.c | 6 +- > > drivers/net/wireless/mwifiex/cmdevt.c | 4 +- > > drivers/net/wireless/mwifiex/fw.h | 30 +++++++++- > > drivers/net/wireless/mwifiex/ie.c | 2 +- > > drivers/net/wireless/mwifiex/join.c | 20 ++++--- > > drivers/net/wireless/mwifiex/main.c | 5 +- > > drivers/net/wireless/mwifiex/main.h | 12 +++- > > drivers/net/wireless/mwifiex/pcie.c | 6 ++ > > drivers/net/wireless/mwifiex/sta_cmd.c | 50 ++++++++++++++-- > > drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 + > > drivers/net/wireless/mwifiex/sta_ioctl.c | 23 +++++++- > > drivers/net/wireless/mwifiex/uap_cmd.c | 6 +- > > drivers/net/wireless/mwifiex/vendor.c | 83 +++++++++++++++++++++++++++ > > drivers/net/wireless/mwifiex/vendor.h | 28 +++++++++ > > 17 files changed, 353 insertions(+), 37 deletions(-) > > create mode 100644 drivers/net/wireless/mwifiex/vendor.c > > create mode 100644 drivers/net/wireless/mwifiex/vendor.h > > > > -- > > kernel-team mailing list > > kernel-team@lists.ubuntu.com > > https://lists.ubuntu.com/mailman/listinfo/kernel-team > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Hi Kamal, There's something wrong with the patch applied on kernel 4.4. The LED does work, but HCI stops working after the LED-on command is issued. I'm trying to figure out what's going wrong. Please drop this patch for this SRU release. Sorry for the inconvenience. Thanks, Jesse 2016-06-21 1:12 GMT+08:00 Kamal Mostafa <kamal@canonical.com>: > On Mon, May 23, 2016 at 06:38:45AM -0700, Kamal Mostafa wrote: >> On Mon, May 23, 2016 at 08:55:19PM +0800, Jesse Sung wrote: >> > BugLink: https://launchpad.net/bugs/1528910 >> > BugLink: https://launchpad.net/bugs/1512997 >> > BugLink: https://launchpad.net/bugs/1512999 >> > >> > V2: Fix Warning in "UBUNTU: SAUCE: mwifiex: add iw vendor command support" >> >> Applied to Xenial. Thanks Jesse! >> > > Hi Jesse- > > You marked one of the three with 'verification-failed-xenial': > > https://launchpad.net/bugs/1512999 > > I have verified that your patch: > > 8b6d64a UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > > is applied in the -proposed kernel (Ubuntu-4.4.0-25.44). Were you (and > are still) able to demonstrate the problem as fixed by that patch in > your own Xenial test build? Whats up here? > > -Kamal > >> >> > >> > The first eight patches are Marvell wireless driver update for FCC regulation. >> > Most of them are in mainline 4.5 except the "add iw vendor command support" one, >> > which is not accepted by upstream[1]. I'm sending it as an Ubuntu sauce before >> > we can have a solution. >> > >> > The last two patches are for WiFi and Bluetooth LEDs on Dell's Edge Gateway. >> > LEDs are connected to GPIOs on Marvell Wifi/BT module, so the code will >> > check if it is run on Edge Gateway before it toggles the LEDs, in case these >> > GPIOs are configured to do something else on other platforms. These two patches >> > are already in vivid kernel for a while. >> > >> > >> > [1] https://marc.info/?l=linux-wireless&m=144982455414246&w=2 >> > >> > ================================================================ >> > The following changes since commit f18d7a47ebd9086e6aa36b823cdce8665efb0c53: >> > >> > UBUNTU: Ubuntu-4.4.0-22.40 (2016-05-12 13:42:19 -0700) >> > >> > are available in the git repository at: >> > >> > https://git.launchpad.net/~wenchien/+git/xenial marvell-v2 >> > >> > for you to fetch changes up to 5ea2e59a3e9f376021a3957ea27f4218fb2b7977: >> > >> > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules >> > (2016-05-23 18:30:16 +0800) >> > >> > ---------------------------------------------------------------- >> > Amitkumar Karwar (7): >> > mwifiex: parse adhoc start/join result >> > mwifiex: handle start AP error paths correctly >> > mwifiex: set regulatory info from EEPROM >> > mwifiex: don't follow AP if country code received from EEPROM >> > mwifiex: correction in region code to country mapping >> > mwifiex: update region_code_index array >> > mwifiex: use world for unidentified region code >> > >> > Wen-chien Jesse Sung (2): >> > UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the >> > device status >> > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules >> > >> > chunfan chen (1): >> > UBUNTU: SAUCE: mwifiex: add iw vendor command support >> > >> > drivers/bluetooth/btusb.c | 92 ++++++++++++++++++++++++++++-- >> > drivers/net/wireless/mwifiex/Makefile | 1 + >> > drivers/net/wireless/mwifiex/cfg80211.c | 20 +++++-- >> > drivers/net/wireless/mwifiex/cfp.c | 6 +- >> > drivers/net/wireless/mwifiex/cmdevt.c | 4 +- >> > drivers/net/wireless/mwifiex/fw.h | 30 +++++++++- >> > drivers/net/wireless/mwifiex/ie.c | 2 +- >> > drivers/net/wireless/mwifiex/join.c | 20 ++++--- >> > drivers/net/wireless/mwifiex/main.c | 5 +- >> > drivers/net/wireless/mwifiex/main.h | 12 +++- >> > drivers/net/wireless/mwifiex/pcie.c | 6 ++ >> > drivers/net/wireless/mwifiex/sta_cmd.c | 50 ++++++++++++++-- >> > drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 + >> > drivers/net/wireless/mwifiex/sta_ioctl.c | 23 +++++++- >> > drivers/net/wireless/mwifiex/uap_cmd.c | 6 +- >> > drivers/net/wireless/mwifiex/vendor.c | 83 +++++++++++++++++++++++++++ >> > drivers/net/wireless/mwifiex/vendor.h | 28 +++++++++ >> > 17 files changed, 353 insertions(+), 37 deletions(-) >> > create mode 100644 drivers/net/wireless/mwifiex/vendor.c >> > create mode 100644 drivers/net/wireless/mwifiex/vendor.h >> > >> > -- >> > kernel-team mailing list >> > kernel-team@lists.ubuntu.com >> > https://lists.ubuntu.com/mailman/listinfo/kernel-team >> >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Tue, Jun 21, 2016 at 03:24:08AM +0800, Jesse Sung wrote: > Hi Kamal, > > There's something wrong with the patch applied on kernel 4.4. The LED > does work, but HCI stops working after the LED-on command is issued. > I'm trying to figure out what's going wrong. Please drop this patch > for this SRU release. Sorry for the inconvenience. Ok, summarizing our IRC discussion: This appears to introduce a new (and worse) failure for Marvell BT but the rest of the patch set is good. Jesse, please test this again ASAP with the problem BT patch either reverted or dropped, then submit the revert of the BT patch to the list here once you're sure. (We'll determine whether applying the revert or dropping the original patch is least painful). -Kamal > > Thanks, > Jesse > > 2016-06-21 1:12 GMT+08:00 Kamal Mostafa <kamal@canonical.com>: > > On Mon, May 23, 2016 at 06:38:45AM -0700, Kamal Mostafa wrote: > >> On Mon, May 23, 2016 at 08:55:19PM +0800, Jesse Sung wrote: > >> > BugLink: https://launchpad.net/bugs/1528910 > >> > BugLink: https://launchpad.net/bugs/1512997 > >> > BugLink: https://launchpad.net/bugs/1512999 > >> > > >> > V2: Fix Warning in "UBUNTU: SAUCE: mwifiex: add iw vendor command support" > >> > >> Applied to Xenial. Thanks Jesse! > >> > > > > Hi Jesse- > > > > You marked one of the three with 'verification-failed-xenial': > > > > https://launchpad.net/bugs/1512999 > > > > I have verified that your patch: > > > > 8b6d64a UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > > > > is applied in the -proposed kernel (Ubuntu-4.4.0-25.44). Were you (and > > are still) able to demonstrate the problem as fixed by that patch in > > your own Xenial test build? Whats up here? > > > > -Kamal > > > >> > >> > > >> > The first eight patches are Marvell wireless driver update for FCC regulation. > >> > Most of them are in mainline 4.5 except the "add iw vendor command support" one, > >> > which is not accepted by upstream[1]. I'm sending it as an Ubuntu sauce before > >> > we can have a solution. > >> > > >> > The last two patches are for WiFi and Bluetooth LEDs on Dell's Edge Gateway. > >> > LEDs are connected to GPIOs on Marvell Wifi/BT module, so the code will > >> > check if it is run on Edge Gateway before it toggles the LEDs, in case these > >> > GPIOs are configured to do something else on other platforms. These two patches > >> > are already in vivid kernel for a while. > >> > > >> > > >> > [1] https://marc.info/?l=linux-wireless&m=144982455414246&w=2 > >> > > >> > ================================================================ > >> > The following changes since commit f18d7a47ebd9086e6aa36b823cdce8665efb0c53: > >> > > >> > UBUNTU: Ubuntu-4.4.0-22.40 (2016-05-12 13:42:19 -0700) > >> > > >> > are available in the git repository at: > >> > > >> > https://git.launchpad.net/~wenchien/+git/xenial marvell-v2 > >> > > >> > for you to fetch changes up to 5ea2e59a3e9f376021a3957ea27f4218fb2b7977: > >> > > >> > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > >> > (2016-05-23 18:30:16 +0800) > >> > > >> > ---------------------------------------------------------------- > >> > Amitkumar Karwar (7): > >> > mwifiex: parse adhoc start/join result > >> > mwifiex: handle start AP error paths correctly > >> > mwifiex: set regulatory info from EEPROM > >> > mwifiex: don't follow AP if country code received from EEPROM > >> > mwifiex: correction in region code to country mapping > >> > mwifiex: update region_code_index array > >> > mwifiex: use world for unidentified region code > >> > > >> > Wen-chien Jesse Sung (2): > >> > UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the > >> > device status > >> > UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules > >> > > >> > chunfan chen (1): > >> > UBUNTU: SAUCE: mwifiex: add iw vendor command support > >> > > >> > drivers/bluetooth/btusb.c | 92 ++++++++++++++++++++++++++++-- > >> > drivers/net/wireless/mwifiex/Makefile | 1 + > >> > drivers/net/wireless/mwifiex/cfg80211.c | 20 +++++-- > >> > drivers/net/wireless/mwifiex/cfp.c | 6 +- > >> > drivers/net/wireless/mwifiex/cmdevt.c | 4 +- > >> > drivers/net/wireless/mwifiex/fw.h | 30 +++++++++- > >> > drivers/net/wireless/mwifiex/ie.c | 2 +- > >> > drivers/net/wireless/mwifiex/join.c | 20 ++++--- > >> > drivers/net/wireless/mwifiex/main.c | 5 +- > >> > drivers/net/wireless/mwifiex/main.h | 12 +++- > >> > drivers/net/wireless/mwifiex/pcie.c | 6 ++ > >> > drivers/net/wireless/mwifiex/sta_cmd.c | 50 ++++++++++++++-- > >> > drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 + > >> > drivers/net/wireless/mwifiex/sta_ioctl.c | 23 +++++++- > >> > drivers/net/wireless/mwifiex/uap_cmd.c | 6 +- > >> > drivers/net/wireless/mwifiex/vendor.c | 83 +++++++++++++++++++++++++++ > >> > drivers/net/wireless/mwifiex/vendor.h | 28 +++++++++ > >> > 17 files changed, 353 insertions(+), 37 deletions(-) > >> > create mode 100644 drivers/net/wireless/mwifiex/vendor.c > >> > create mode 100644 drivers/net/wireless/mwifiex/vendor.h > >> > > >> > -- > >> > kernel-team mailing list > >> > kernel-team@lists.ubuntu.com > >> > https://lists.ubuntu.com/mailman/listinfo/kernel-team > >> > >> -- > >> kernel-team mailing list > >> kernel-team@lists.ubuntu.com > >> https://lists.ubuntu.com/mailman/listinfo/kernel-team
BugLink: https://launchpad.net/bugs/1528910 BugLink: https://launchpad.net/bugs/1512997 BugLink: https://launchpad.net/bugs/1512999 V2: Fix Warning in "UBUNTU: SAUCE: mwifiex: add iw vendor command support" The first eight patches are Marvell wireless driver update for FCC regulation. Most of them are in mainline 4.5 except the "add iw vendor command support" one, which is not accepted by upstream[1]. I'm sending it as an Ubuntu sauce before we can have a solution. The last two patches are for WiFi and Bluetooth LEDs on Dell's Edge Gateway. LEDs are connected to GPIOs on Marvell Wifi/BT module, so the code will check if it is run on Edge Gateway before it toggles the LEDs, in case these GPIOs are configured to do something else on other platforms. These two patches are already in vivid kernel for a while. [1] https://marc.info/?l=linux-wireless&m=144982455414246&w=2 ================================================================ The following changes since commit f18d7a47ebd9086e6aa36b823cdce8665efb0c53: UBUNTU: Ubuntu-4.4.0-22.40 (2016-05-12 13:42:19 -0700) are available in the git repository at: https://git.launchpad.net/~wenchien/+git/xenial marvell-v2 for you to fetch changes up to 5ea2e59a3e9f376021a3957ea27f4218fb2b7977: UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules (2016-05-23 18:30:16 +0800) ---------------------------------------------------------------- Amitkumar Karwar (7): mwifiex: parse adhoc start/join result mwifiex: handle start AP error paths correctly mwifiex: set regulatory info from EEPROM mwifiex: don't follow AP if country code received from EEPROM mwifiex: correction in region code to country mapping mwifiex: update region_code_index array mwifiex: use world for unidentified region code Wen-chien Jesse Sung (2): UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the device status UBUNTU: SAUCE: Bluetooth: Support for LED on Marvell modules chunfan chen (1): UBUNTU: SAUCE: mwifiex: add iw vendor command support drivers/bluetooth/btusb.c | 92 ++++++++++++++++++++++++++++-- drivers/net/wireless/mwifiex/Makefile | 1 + drivers/net/wireless/mwifiex/cfg80211.c | 20 +++++-- drivers/net/wireless/mwifiex/cfp.c | 6 +- drivers/net/wireless/mwifiex/cmdevt.c | 4 +- drivers/net/wireless/mwifiex/fw.h | 30 +++++++++- drivers/net/wireless/mwifiex/ie.c | 2 +- drivers/net/wireless/mwifiex/join.c | 20 ++++--- drivers/net/wireless/mwifiex/main.c | 5 +- drivers/net/wireless/mwifiex/main.h | 12 +++- drivers/net/wireless/mwifiex/pcie.c | 6 ++ drivers/net/wireless/mwifiex/sta_cmd.c | 50 ++++++++++++++-- drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 + drivers/net/wireless/mwifiex/sta_ioctl.c | 23 +++++++- drivers/net/wireless/mwifiex/uap_cmd.c | 6 +- drivers/net/wireless/mwifiex/vendor.c | 83 +++++++++++++++++++++++++++ drivers/net/wireless/mwifiex/vendor.h | 28 +++++++++ 17 files changed, 353 insertions(+), 37 deletions(-) create mode 100644 drivers/net/wireless/mwifiex/vendor.c create mode 100644 drivers/net/wireless/mwifiex/vendor.h