diff mbox

i2c: I2C_RCAR should depend on HAS_DMA

Message ID 1463902715-12680-1-git-send-email-geert@linux-m68k.org
State Accepted
Headers show

Commit Message

Geert Uytterhoeven May 22, 2016, 7:38 a.m. UTC
If NO_DMA=y:

    drivers/built-in.o: In function `rcar_i2c_dma_unmap':
    i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
    drivers/built-in.o: In function `rcar_i2c_dma':
    i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
    i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Niklas Söderlund May 22, 2016, 9:45 a.m. UTC | #1
Hi Geert,

On 2016-05-22 09:38:35 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `rcar_i2c_dma_unmap':
>     i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
>     drivers/built-in.o: In function `rcar_i2c_dma':
>     i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
>     i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 2dd40ddf04de3117..8ffb0d7015b0f4fe 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -985,6 +985,7 @@ config I2C_XLP9XX
>  
>  config I2C_RCAR
>  	tristate "Renesas R-Car I2C Controller"
> +	depends on HAS_DMA
>  	depends on ARCH_RENESAS || COMPILE_TEST
>  	select I2C_SLAVE
>  	help
> -- 
> 1.9.1
>
Wolfram Sang May 26, 2016, 6:44 p.m. UTC | #2
On Sun, May 22, 2016 at 09:38:35AM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `rcar_i2c_dma_unmap':
>     i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
>     drivers/built-in.o: In function `rcar_i2c_dma':
>     i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
>     i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied to for-next, thanks!
diff mbox

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 2dd40ddf04de3117..8ffb0d7015b0f4fe 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -985,6 +985,7 @@  config I2C_XLP9XX
 
 config I2C_RCAR
 	tristate "Renesas R-Car I2C Controller"
+	depends on HAS_DMA
 	depends on ARCH_RENESAS || COMPILE_TEST
 	select I2C_SLAVE
 	help