Patchwork : Possibly uninitialized variable in tree-vect-loop.c

login
register
mail settings
Submitter Kai Tietz
Date Aug. 23, 2010, 6:36 a.m.
Message ID <AANLkTi=-TebGsBtPsj+SKtC8C0uAU3KTqVGMYdGRMgF1@mail.gmail.com>
Download mbox | patch
Permalink /patch/62448/
State New
Headers show

Comments

Kai Tietz - Aug. 23, 2010, 6:36 a.m.
Hi,

Somehow the diagnostic of 4.6 about possible unitialized variables is
a bit vague. By using an older gcc for bootstrapping I found a case in
tree-vect-loop.c, which indeed has unitialized variable in some
branches.
This patch fixes it.

ChangeLog

2010-08-23  Kai Tietz

        * tree-vect-loop.c (vect_get_single_scalar_iteraion_cost):
Pre-initialize innerloop_iters to one.

Tested for x86_64-pc-linux-gnu, x86_64-w64-mingw32, and
i686-w64-mingw32. Ok for apply?

Regards,
Kai
Richard Guenther - Aug. 23, 2010, 5:11 p.m.
On Mon, Aug 23, 2010 at 8:36 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> Hi,
>
> Somehow the diagnostic of 4.6 about possible unitialized variables is
> a bit vague. By using an older gcc for bootstrapping I found a case in
> tree-vect-loop.c, which indeed has unitialized variable in some
> branches.

Ok.

Thanks,
Richard.

> This patch fixes it.
>
> ChangeLog
>
> 2010-08-23  Kai Tietz
>
>        * tree-vect-loop.c (vect_get_single_scalar_iteraion_cost):
> Pre-initialize innerloop_iters to one.
>
> Tested for x86_64-pc-linux-gnu, x86_64-w64-mingw32, and
> i686-w64-mingw32. Ok for apply?
>
> Regards,
> Kai
>
> Index: tree-vect-loop.c
> ===================================================================
> --- tree-vect-loop.c    (revision 163445)
> +++ tree-vect-loop.c    (working copy)
> @@ -2031,6 +2031,7 @@
>      statements.  */
>
>   /* FORNOW.  */
> +  innerloop_iters = 1;
>   if (loop->inner)
>     innerloop_iters = 50; /* FIXME */
>
>
> --
> |  (\_/) This is Bunny. Copy and paste
> | (='.'=) Bunny into your signature to help
> | (")_(") him gain world domination
>
Kai Tietz - Aug. 23, 2010, 6:09 p.m.
2010/8/23 Richard Guenther <richard.guenther@gmail.com>:
> On Mon, Aug 23, 2010 at 8:36 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>> Hi,
>>
>> Somehow the diagnostic of 4.6 about possible unitialized variables is
>> a bit vague. By using an older gcc for bootstrapping I found a case in
>> tree-vect-loop.c, which indeed has unitialized variable in some
>> branches.
>
> Ok.
>
> Thanks,
> Richard.

Applied at revision 163477.

Kai

Patch

Index: tree-vect-loop.c
===================================================================
--- tree-vect-loop.c    (revision 163445)
+++ tree-vect-loop.c    (working copy)
@@ -2031,6 +2031,7 @@ 
      statements.  */

   /* FORNOW.  */
+  innerloop_iters = 1;
   if (loop->inner)
     innerloop_iters = 50; /* FIXME */