diff mbox

[3/9] Fix leak in gcc/tree-ssa-reassoc.c.

Message ID a0c32ef8bc5ba2687803785470f2490401828181.1463654693.git.mliska@suse.cz
State New
Headers show

Commit Message

Martin Liška May 19, 2016, 10:44 a.m. UTC 
Leak can be seen e.g. here:
gcc reassoc-11.c -fno-diagnostics-show-caret -fdiagnostics-color=never -O2 -fdump-tree-reassoc1

gcc/ChangeLog:

2016-05-18  Martin Liska  <mliska@suse.cz>

	* tree-ssa-reassoc.c (eliminate_duplicate_pair): Truncate
	an auto_vec instead of re-creating it.
---
 gcc/tree-ssa-reassoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Biener May 19, 2016, 11:16 a.m. UTC | #1 
On Thu, May 19, 2016 at 12:44 PM, marxin <mliska@suse.cz> wrote:
> Leak can be seen e.g. here:
> gcc reassoc-11.c -fno-diagnostics-show-caret -fdiagnostics-color=never -O2 -fdump-tree-reassoc1

Ok.

Richard.

> gcc/ChangeLog:
>
> 2016-05-18  Martin Liska  <mliska@suse.cz>
>
>         * tree-ssa-reassoc.c (eliminate_duplicate_pair): Truncate
>         an auto_vec instead of re-creating it.
> ---
>  gcc/tree-ssa-reassoc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c
> index 3b5f36b..81b8977 100644
> --- a/gcc/tree-ssa-reassoc.c
> +++ b/gcc/tree-ssa-reassoc.c
> @@ -732,7 +732,7 @@ eliminate_duplicate_pair (enum tree_code opcode,
>
>           if (ops->length () == 2)
>             {
> -             ops->create (0);
> +             ops->truncate (0);
>               add_to_ops_vec (ops, build_zero_cst (TREE_TYPE (last->op)));
>               *all_done = true;
>             }
> --
> 2.8.2
>
>
diff mbox

Patch

diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c
index 3b5f36b..81b8977 100644
--- a/gcc/tree-ssa-reassoc.c
+++ b/gcc/tree-ssa-reassoc.c
@@ -732,7 +732,7 @@  eliminate_duplicate_pair (enum tree_code opcode,
 
 	  if (ops->length () == 2)
 	    {
-	      ops->create (0);
+	      ops->truncate (0);
 	      add_to_ops_vec (ops, build_zero_cst (TREE_TYPE (last->op)));
 	      *all_done = true;
 	    }