diff mbox

[U-Boot,04/21] tools: moveconfig: check directory relocation before compilers

Message ID 1463640729-25666-5-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 4b430c983a57146633f1b9a9ca5ed7289215763f
Delegated to: Masahiro Yamada
Headers show

Commit Message

Masahiro Yamada May 19, 2016, 6:51 a.m. UTC
We must make sure this tool is run from the top of source directory
before calling update_cross_compile().  Otherwise, the following
exception is thrown:

Traceback (most recent call last):
  File "./moveconfig.py", line 918, in <module>
    main()
  File "./moveconfig.py", line 908, in main
    update_cross_compile()
  File "./moveconfig.py", line 292, in update_cross_compile
    for arch in os.listdir('arch'):
OSError: [Errno 2] No such file or directory: 'arch'

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 tools/moveconfig.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joe Hershberger May 24, 2016, 2:27 p.m. UTC | #1
On Thu, May 19, 2016 at 1:51 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> We must make sure this tool is run from the top of source directory
> before calling update_cross_compile().  Otherwise, the following
> exception is thrown:
>
> Traceback (most recent call last):
>   File "./moveconfig.py", line 918, in <module>
>     main()
>   File "./moveconfig.py", line 908, in main
>     update_cross_compile()
>   File "./moveconfig.py", line 292, in update_cross_compile
>     for arch in os.listdir('arch'):
> OSError: [Errno 2] No such file or directory: 'arch'
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox

Patch

diff --git a/tools/moveconfig.py b/tools/moveconfig.py
index 1332bd2..ce8245a 100755
--- a/tools/moveconfig.py
+++ b/tools/moveconfig.py
@@ -905,10 +905,10 @@  def main():
 
     config_attrs = parse_recipe(args[0])
 
-    update_cross_compile()
-
     check_top_directory()
 
+    update_cross_compile()
+
     if not options.cleanup_headers_only:
         move_config(config_attrs, options)