Message ID | 1463511883-27657-1-git-send-email-matthew.weber@rockwellcollins.com |
---|---|
State | Changes Requested |
Headers | show |
Hello, On Tue, 17 May 2016 14:04:40 -0500, Matt Weber wrote: > +ifeq ($(BR2_powerpc64), y) Remove the sparc before "y". > + EXTRA_FLAGS = "M64BIT=1" EXTRA_FLAGS is not a proper variable name. Remember that the variable namespace is global in Buildroot, to *all* variables should be prefixed by the name of the package they are related to. However, in this case, why not just appending to FMC_MAKE_OPTS ? Also, your double quotes are not needed. > +else > + EXTRA_FLAGS = "" Not needed. > define FMC_BUILD_CMDS > # The linking step has dependency issues so using MAKE1 > - $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) -C $(@D)/source > + $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) $(call qstrip,$(EXTRA_FLAGS)) -C $(@D)/source Change not needed if you append to FMC_MAKE_OPTS. So, the only change needed to the .mk file is: ifeq ($(BR2_powerpc64),y) FMC_MAKE_OPTS += M64BIT=1 endif Can you rework this? Thanks! Thomas
Thomas, On Tue, May 17, 2016 at 2:14 PM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Tue, 17 May 2016 14:04:40 -0500, Matt Weber wrote: > > > +ifeq ($(BR2_powerpc64), y) > > Remove the sparc before "y". > > > + EXTRA_FLAGS = "M64BIT=1" > > EXTRA_FLAGS is not a proper variable name. Remember that the variable > namespace is global in Buildroot, to *all* variables should be prefixed > by the name of the package they are related to. > > However, in this case, why not just appending to FMC_MAKE_OPTS ? > > Also, your double quotes are not needed. > > > +else > > + EXTRA_FLAGS = "" > > Not needed. > > > define FMC_BUILD_CMDS > > # The linking step has dependency issues so using MAKE1 > > - $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) -C $(@D)/source > > + $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) $(call > qstrip,$(EXTRA_FLAGS)) -C $(@D)/source > > Change not needed if you append to FMC_MAKE_OPTS. > > So, the only change needed to the .mk file is: > > ifeq ($(BR2_powerpc64),y) > FMC_MAKE_OPTS += M64BIT=1 > endif > > Can you rework this? > Will do. -Matt
Thomas, On Tue, May 17, 2016 at 4:11 PM, Matthew Weber < matthew.weber@rockwellcollins.com> wrote: > Thomas, > > On Tue, May 17, 2016 at 2:14 PM, Thomas Petazzoni < > thomas.petazzoni@free-electrons.com> wrote: > >> Hello, >> >> On Tue, 17 May 2016 14:04:40 -0500, Matt Weber wrote: >> >> > +ifeq ($(BR2_powerpc64), y) >> >> Remove the sparc before "y". >> >> > + EXTRA_FLAGS = "M64BIT=1" >> >> EXTRA_FLAGS is not a proper variable name. Remember that the variable >> namespace is global in Buildroot, to *all* variables should be prefixed >> by the name of the package they are related to. >> >> However, in this case, why not just appending to FMC_MAKE_OPTS ? >> >> Also, your double quotes are not needed. >> >> > +else >> > + EXTRA_FLAGS = "" >> >> Not needed. >> >> > define FMC_BUILD_CMDS >> > Thanks for the note on PLATFORM not being used. I was missing a commit set in my original patches. In both fmc and fmlib I plan to add something like the following as the first step in the BUILD_CMD $(SED) "s:P4080:$(FMLIB_PLATFORM):g" $(@D)/source/Makefile > > # The linking step has dependency issues so using MAKE1 >> > - $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) -C $(@D)/source >> > + $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) $(call >> qstrip,$(EXTRA_FLAGS)) -C $(@D)/source >> >> Change not needed if you append to FMC_MAKE_OPTS. >> >> So, the only change needed to the .mk file is: >> >> ifeq ($(BR2_powerpc64),y) >> FMC_MAKE_OPTS += M64BIT=1 >> endif >> >> Can you rework this? >> > > Will do. > > -Matt >
diff --git a/package/fmc/Config.in b/package/fmc/Config.in index a50f80d..b7398e2 100644 --- a/package/fmc/Config.in +++ b/package/fmc/Config.in @@ -1,14 +1,14 @@ comment "fmc needs a toolchain w/ C++" - depends on BR2_powerpc_e500mc + depends on BR2_powerpc_e500mc || BR2_powerpc_e6500 depends on !BR2_INSTALL_LIBSTDCPP comment "fmc needs a Linux kernel to be built" - depends on BR2_powerpc_e500mc + depends on BR2_powerpc_e500mc || BR2_powerpc_e6500 depends on !BR2_LINUX_KERNEL config BR2_PACKAGE_FMC bool "fmc" - depends on BR2_powerpc_e500mc + depends on BR2_powerpc_e500mc || BR2_powerpc_e6500 depends on BR2_INSTALL_LIBSTDCPP depends on BR2_LINUX_KERNEL # fmlib select BR2_PACKAGE_TCLAP diff --git a/package/fmc/fmc.mk b/package/fmc/fmc.mk index 49c5fe8..4712385 100644 --- a/package/fmc/fmc.mk +++ b/package/fmc/fmc.mk @@ -18,9 +18,15 @@ FMC_MAKE_OPTS = \ LIBXML2_HEADER_PATH="$(STAGING_DIR)/usr/include/libxml2" \ TCLAP_HEADER_PATH="$(STAGING_DIR)/usr/include" +ifeq ($(BR2_powerpc64), y) + EXTRA_FLAGS = "M64BIT=1" +else + EXTRA_FLAGS = "" +endif + define FMC_BUILD_CMDS # The linking step has dependency issues so using MAKE1 - $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) -C $(@D)/source + $(TARGET_MAKE_ENV) $(MAKE1) $(FMC_MAKE_OPTS) $(call qstrip,$(EXTRA_FLAGS)) -C $(@D)/source endef define FMC_INSTALL_TARGET_CMDS
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> --- package/fmc/Config.in | 6 +++--- package/fmc/fmc.mk | 8 +++++++- 2 files changed, 10 insertions(+), 4 deletions(-)