diff mbox

[1/1] package/vlc: configure.ac does not support --en/--disable-freerdp

Message ID 1463511419-31833-1-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls May 17, 2016, 6:56 p.m. UTC
Vlc configure does not allow disabling freerdp support:
http://git.videolan.org/?p=vlc/vlc-2.2.git;a=blob;f=configure.ac;h=e021546e284d7daefdb4d94f430eb0bc57722210;hb=HEAD#l1890

The problem

configure: WARNING: unrecognized options: --disable-gtk-doc,
 --disable-gtk-doc-html, --disable-doc, --disable-docs,
 --disable-documentation, --with-xmlto, --with-fop, --enable-ipv6,
 --disable-libfreerdp

can be seen for example in

http://autobuild.buildroot.net/results/1a7/1a7893c13f6144e0ecd9f37f2f047c596ccedd35/build-end.log
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/vlc/vlc.mk | 3 ---
 1 file changed, 3 deletions(-)

Comments

Thomas Petazzoni May 17, 2016, 7:24 p.m. UTC | #1
Hello,

On Tue, 17 May 2016 20:56:59 +0200, Bernd Kuhls wrote:
> Vlc configure does not allow disabling freerdp support:
> http://git.videolan.org/?p=vlc/vlc-2.2.git;a=blob;f=configure.ac;h=e021546e284d7daefdb4d94f430eb0bc57722210;hb=HEAD#l1890
> 
> The problem
> 
> configure: WARNING: unrecognized options: --disable-gtk-doc,
>  --disable-gtk-doc-html, --disable-doc, --disable-docs,
>  --disable-documentation, --with-xmlto, --with-fop, --enable-ipv6,
>  --disable-libfreerdp
> 
> can be seen for example in
> 
> http://autobuild.buildroot.net/results/1a7/1a7893c13f6144e0ecd9f37f2f047c596ccedd35/build-end.log

Missing empty new line here.

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/vlc/vlc.mk | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
> index 30887bd..4dc8dfe 100644
> --- a/package/vlc/vlc.mk
> +++ b/package/vlc/vlc.mk
> @@ -137,10 +137,7 @@ VLC_CONF_OPTS += --disable-flac
>  endif
>  
>  ifeq ($(BR2_PACKAGE_FREERDP),y)
> -VLC_CONF_OPTS += --enable-freerdp
>  VLC_DEPENDENCIES += freerdp
> -else
> -VLC_CONF_OPTS += --disable-libfreerdp
>  endif

Several things are not clear for me here:

 1/ Is freerdp an optional or a mandatory dependency of VLC ?

 2/ Who is this freerdp thing related to a link failure against -lGL ?

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 30887bd..4dc8dfe 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -137,10 +137,7 @@  VLC_CONF_OPTS += --disable-flac
 endif
 
 ifeq ($(BR2_PACKAGE_FREERDP),y)
-VLC_CONF_OPTS += --enable-freerdp
 VLC_DEPENDENCIES += freerdp
-else
-VLC_CONF_OPTS += --disable-libfreerdp
 endif
 
 ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)