diff mbox

[AArch64] Delete ASM_OUTPUT_DEF and fallback to default .set directive

Message ID 1463476406-839-1-git-send-email-james.greenhalgh@arm.com
State New
Headers show

Commit Message

James Greenhalgh May 17, 2016, 9:13 a.m. UTC 
Hi,

As in the ARM port [1] , the AArch64 port wants to put out "b = a" to set
an alias. This doesn't cause us any trouble yet, as the AArch64 port doesn't
warn for this construct - but at the same time there is no reason for us
not to put out a .set directive - this seems to have been copied from the
ARM port when section anchor support was added in 2012. Looking through
the chain, we'll get a default definition for ASM_OUTPUT_DEF if SET_ASM_OP
is defined, and we get SET_ASM_OP defined through config/elfos.h for
all the AArch64 targets I can see in config.gcc. So we're safe to drop
this.

Bootstrapped on aarch64-none-linux-gnu.

OK?

Thanks,
James

[1]: https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01691.html

---
2016-05-17  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/aarch64/aarch64-elf.h (ASM_OUTPUT_DEF): Delete.

Comments

Marcus Shawcroft May 17, 2016, 10:30 a.m. UTC | #1 
On 17 May 2016 at 10:13, James Greenhalgh <james.greenhalgh@arm.com> wrote:
>
> Hi,
>
> As in the ARM port [1] , the AArch64 port wants to put out "b = a" to set
> an alias. This doesn't cause us any trouble yet, as the AArch64 port doesn't
> warn for this construct - but at the same time there is no reason for us
> not to put out a .set directive - this seems to have been copied from the
> ARM port when section anchor support was added in 2012. Looking through
> the chain, we'll get a default definition for ASM_OUTPUT_DEF if SET_ASM_OP
> is defined, and we get SET_ASM_OP defined through config/elfos.h for
> all the AArch64 targets I can see in config.gcc. So we're safe to drop
> this.
>
> Bootstrapped on aarch64-none-linux-gnu.
>
> OK?

OK /Marcus
diff mbox

Patch

diff --git a/gcc/config/aarch64/aarch64-elf.h b/gcc/config/aarch64/aarch64-elf.h
index 66c0bb2..1fbee6f 100644
--- a/gcc/config/aarch64/aarch64-elf.h
+++ b/gcc/config/aarch64/aarch64-elf.h
@@ -25,15 +25,6 @@ 
 #define ASM_OUTPUT_LABELREF(FILE, NAME) \
   aarch64_asm_output_labelref (FILE, NAME)
 
-#define ASM_OUTPUT_DEF(FILE, NAME1, NAME2)	\
-  do						\
-    {						\
-      assemble_name (FILE, NAME1);		\
-      fputs (" = ", FILE);			\
-      assemble_name (FILE, NAME2);		\
-      fputc ('\n', FILE);			\
-    } while (0)
-
 #define TEXT_SECTION_ASM_OP	"\t.text"
 #define DATA_SECTION_ASM_OP	"\t.data"
 #define BSS_SECTION_ASM_OP	"\t.bss"