| Submitter | Jon Povey |
|---|---|
| Date | Aug. 20, 2010, 8:11 a.m. |
| Message ID | <1282291879-28754-1-git-send-email-jon.povey@racelogic.co.uk> |
| Download | mbox | patch |
| Permalink | /patch/62257/ |
| State | New |
| Headers | show |
Comments
On 08/20/2010 01:11 AM, Jon Povey wrote: > Hex dumps were being printed with the nybbles reversed since > commit 6ff458433ba15b8a7cb258ce64e64e98982df26e > Fix. Haha, wow. I'm pretty sure that when porting the kernel function over, I noticed that, then promptly ignored it. Good catch! Thanks, Brian
On Fri, 2010-08-20 at 12:03 -0700, Brian Norris wrote: > On 08/20/2010 01:11 AM, Jon Povey wrote: > > Hex dumps were being printed with the nybbles reversed since > > commit 6ff458433ba15b8a7cb258ce64e64e98982df26e > > Fix. > > Haha, wow. I'm pretty sure that when porting the kernel function over, I > noticed that, then promptly ignored it. Good catch! Just FYI, if you approve a patch, it is good to send Acked-by line which I can copy-paste.
On Fri, 2010-08-20 at 17:11 +0900, Jon Povey wrote: > Hex dumps were being printed with the nybbles reversed since > commit 6ff458433ba15b8a7cb258ce64e64e98982df26e > Fix. > > Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk> > CC: Brian Norris <norris@broadcom.com> > --- > nanddump.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Pushed, thank you!
Patch
diff --git a/nanddump.c b/nanddump.c index acfdb33..22fec5f 100644 --- a/nanddump.c +++ b/nanddump.c @@ -239,8 +239,8 @@ static void pretty_dump_to_buffer(const unsigned char *buf, size_t len, for (j = 0; (j < len) && (lx + 3) <= linebuflen; j++) { ch = buf[j]; - linebuf[lx++] = hex_asc[ch & 0x0f]; linebuf[lx++] = hex_asc[(ch & 0xf0) >> 4]; + linebuf[lx++] = hex_asc[ch & 0x0f]; linebuf[lx++] = ' '; } if (j)
Hex dumps were being printed with the nybbles reversed since commit 6ff458433ba15b8a7cb258ce64e64e98982df26e Fix. Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk> CC: Brian Norris <norris@broadcom.com> --- nanddump.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)