From patchwork Wed Oct 29 08:24:59 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 6223 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CB479DDDF5 for ; Wed, 29 Oct 2008 19:25:32 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbYJ2IZ2 (ORCPT ); Wed, 29 Oct 2008 04:25:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752309AbYJ2IZ2 (ORCPT ); Wed, 29 Oct 2008 04:25:28 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:55718 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbYJ2IZ1 (ORCPT ); Wed, 29 Oct 2008 04:25:27 -0400 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1Kv6MR-0005NV-UP from ; Wed, 29 Oct 2008 09:25:10 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id B765C3E21A3; Wed, 29 Oct 2008 09:24:58 +0100 (CET) Date: Wed, 29 Oct 2008 09:24:59 +0100 From: Ingo Molnar To: xfs-masters@oss.sgi.com, Thomas Gleixner , Dave Airlie , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, Herbert Xu , Paul Moore , Takashi Iwai , Pekka Enberg Subject: Re: [xfs-masters] linux-next: arm allmodconfig Message-ID: <20081029082459.GA6364@elte.hu> References: <20081028175604.81c31cea.akpm@linux-foundation.org> <20081029074032.GI4985@disturbed> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081029074032.GI4985@disturbed> User-Agent: Mutt/1.5.18 (2008-05-17) Received-SPF: neutral (mx2: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00, DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Dave Chinner wrote: > > > fs/xfs/xfs_rtalloc.c: In function `xfs_growfs_rt': > > > fs/xfs/xfs_rtalloc.c:1875: warning: 'tp' might be used uninitialized in this function > > False positive, and I don't get this reported, either. > > Hold on - the above gcc binary only emits a warning for the > xfs_growfs_rt issue when CONFIG_CC_OPTIMIZE_FOR_SIZE=y is set. It > still doesn't catch the quota bug, though. This is so fucked up.... FYI, i've got 3 XFS warnings mapped in tip/auto-warnings-next: earth4:~/tip> gll linus..auto-warnings-next | grep xfs ec2f37c: work around warning in fs/xfs/xfs_mount.c 8501db3: work around warning in fs/xfs/xfs_rtalloc.c 8077af8: warnings: fix xfs posix acl you can find those commits in the auto-warnings-next branch of -tip: http://people.redhat.com/mingo/tip.git/README the rtalloc annotation is below. I went through the flow and the code seems to be correct and GCC is wrong. Ingo -------------> From 8501db35588df4f35d67d8ba207422006a214ae7 Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Mon, 18 Aug 2008 15:21:19 +0200 Subject: [PATCH] work around warning in fs/xfs/xfs_rtalloc.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fix warning: fs/xfs/xfs_rtalloc.c: In function ‘xfs_growfs_rt’: fs/xfs/xfs_rtalloc.c:1875: warning: ‘tp’ may be used uninitialized in this function This is a spurious gcc warning - it does not realize the correct/bug-free flow of logic regarding the 'error' and 'tp' variables. No code changed: 7c10fd959065115c8e252ff5a861a01e xfs_rtalloc.o.before.asm 7c10fd959065115c8e252ff5a861a01e xfs_rtalloc.o.after.asm Signed-off-by: Ingo Molnar --- fs/xfs/xfs_rtalloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c index e2f68de..fe5de08 100644 --- a/fs/xfs/xfs_rtalloc.c +++ b/fs/xfs/xfs_rtalloc.c @@ -1872,7 +1872,7 @@ xfs_growfs_rt( xfs_extlen_t rsumblocks; /* current number of rt summary blks */ xfs_sb_t *sbp; /* old superblock */ xfs_fsblock_t sumbno; /* summary block number */ - xfs_trans_t *tp; /* transaction pointer */ + xfs_trans_t *uninitialized_var(tp); /* transaction pointer */ sbp = &mp->m_sb; cancelflags = 0;