Message ID | 20081029082459.GA6364@elte.hu |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, Oct 29, 2008 at 09:24:59AM +0100, Ingo Molnar wrote: > > * Dave Chinner <david@fromorbit.com> wrote: > > > > > fs/xfs/xfs_rtalloc.c: In function `xfs_growfs_rt': > > > > fs/xfs/xfs_rtalloc.c:1875: warning: 'tp' might be used uninitialized in this function > > > > False positive, and I don't get this reported, either. > > > > Hold on - the above gcc binary only emits a warning for the > > xfs_growfs_rt issue when CONFIG_CC_OPTIMIZE_FOR_SIZE=y is set. It > > still doesn't catch the quota bug, though. This is so fucked up.... > > FYI, i've got 3 XFS warnings mapped in tip/auto-warnings-next: > > earth4:~/tip> gll linus..auto-warnings-next | grep xfs > > ec2f37c: work around warning in fs/xfs/xfs_mount.c Can't say I've ever seen that warning. What gcc version is generating it? > 8501db3: work around warning in fs/xfs/xfs_rtalloc.c Yeah, that's bogus. > 8077af8: warnings: fix xfs posix acl Should be fixed in the -next tree. Cheers, Dave.
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c index e2f68de..fe5de08 100644 --- a/fs/xfs/xfs_rtalloc.c +++ b/fs/xfs/xfs_rtalloc.c @@ -1872,7 +1872,7 @@ xfs_growfs_rt( xfs_extlen_t rsumblocks; /* current number of rt summary blks */ xfs_sb_t *sbp; /* old superblock */ xfs_fsblock_t sumbno; /* summary block number */ - xfs_trans_t *tp; /* transaction pointer */ + xfs_trans_t *uninitialized_var(tp); /* transaction pointer */ sbp = &mp->m_sb; cancelflags = 0;