| Message ID | 20160513093010.GA8419@workbook.ipv6.hrusecky.net |
|---|---|
| State | Changes Requested |
| Delegated to: | John Crispin |
| Headers | show |
Hi Michal, On Fri, May 13, 2016 at 11:30:10AM +0200, Michal Hrusecky wrote: > Adding new Marvell cryptoengine as some device might use the new one and not > the old one. I'm assuming that the "New Marvell crypto engine" is taken from mainline kernel. Since the "Old Marvell crypto engine" is not in mainline I'd rather that somewhere along the line it gets replaced entirely by the mainline one. That said, can you send v2 where you remove the "New" from the Title and make it depend on a newer mainline kernels which have support for this crypto engine. Thanks, Luka > Signed-off-by: Michal Hrusecky <michal.hrusecky@nic.cz> > --- > package/kernel/linux/modules/crypto.mk | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/package/kernel/linux/modules/crypto.mk b/package/kernel/linux/modules/crypto.mk > index 0acc730..0f37a55 100644 > --- a/package/kernel/linux/modules/crypto.mk > +++ b/package/kernel/linux/modules/crypto.mk > @@ -711,14 +711,28 @@ endef > > $(eval $(call KernelPackage,crypto-xts)) > > - > define KernelPackage/crypto-mv-cesa > - TITLE:=Marvell crypto engine > + TITLE:=Old Marvell crypto engine > DEPENDS:=+kmod-crypto-manager @TARGET_kirkwood||TARGET_orion||TARGET_mvebu > - KCONFIG:=CONFIG_CRYPTO_DEV_MV_CESA > + KCONFIG:= \ > + CONFIG_CRYPTO_DEV_MV_CESA \ > + CONFIG_CRYPTO_HW=y > FILES:=$(LINUX_DIR)/drivers/crypto/mv_cesa.ko > AUTOLOAD:=$(call AutoLoad,09,mv_cesa) > $(call AddDepends/crypto) > endef > > $(eval $(call KernelPackage,crypto-mv-cesa)) > + > +define KernelPackage/crypto-marvell-cesa > + TITLE:=New Marvell crypto engine > + DEPENDS:=+kmod-crypto-manager @TARGET_kirkwood||TARGET_orion||TARGET_mvebu > + KCONFIG:= \ > + CONFIG_CRYPTO_DEV_MARVELL_CESA \ > + CONFIG_CRYPTO_HW=y > + FILES:=$(LINUX_DIR)/drivers/crypto/marvell/marvell-cesa.ko > + AUTOLOAD:=$(call AutoLoad,09,marvell-cesa) > + $(call AddDepends/crypto) > +endef > + > +$(eval $(call KernelPackage,crypto-marvell-cesa)) > -- > 2.8.2 > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
diff --git a/package/kernel/linux/modules/crypto.mk b/package/kernel/linux/modules/crypto.mk index 0acc730..0f37a55 100644 --- a/package/kernel/linux/modules/crypto.mk +++ b/package/kernel/linux/modules/crypto.mk @@ -711,14 +711,28 @@ endef $(eval $(call KernelPackage,crypto-xts)) - define KernelPackage/crypto-mv-cesa - TITLE:=Marvell crypto engine + TITLE:=Old Marvell crypto engine DEPENDS:=+kmod-crypto-manager @TARGET_kirkwood||TARGET_orion||TARGET_mvebu - KCONFIG:=CONFIG_CRYPTO_DEV_MV_CESA + KCONFIG:= \ + CONFIG_CRYPTO_DEV_MV_CESA \ + CONFIG_CRYPTO_HW=y FILES:=$(LINUX_DIR)/drivers/crypto/mv_cesa.ko AUTOLOAD:=$(call AutoLoad,09,mv_cesa) $(call AddDepends/crypto) endef $(eval $(call KernelPackage,crypto-mv-cesa)) + +define KernelPackage/crypto-marvell-cesa + TITLE:=New Marvell crypto engine + DEPENDS:=+kmod-crypto-manager @TARGET_kirkwood||TARGET_orion||TARGET_mvebu + KCONFIG:= \ + CONFIG_CRYPTO_DEV_MARVELL_CESA \ + CONFIG_CRYPTO_HW=y + FILES:=$(LINUX_DIR)/drivers/crypto/marvell/marvell-cesa.ko + AUTOLOAD:=$(call AutoLoad,09,marvell-cesa) + $(call AddDepends/crypto) +endef + +$(eval $(call KernelPackage,crypto-marvell-cesa))
Adding new Marvell cryptoengine as some device might use the new one and not the old one. Signed-off-by: Michal Hrusecky <michal.hrusecky@nic.cz> --- package/kernel/linux/modules/crypto.mk | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)