| Message ID | 1463077504-3646-1-git-send-email-ps.report@gmx.net |
|---|---|
| State | Changes Requested |
| Headers | show |
On 05/12/16 20:25, Peter Seiderer wrote: > Set uclibc DODEBUG in case BR2_ENABLE_DEBUG is set. > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > package/uclibc/uclibc.mk | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk > index b8ccee2..d68385d 100644 > --- a/package/uclibc/uclibc.mk > +++ b/package/uclibc/uclibc.mk > @@ -182,6 +182,15 @@ endef > endif > > # > +# Debug > +# > +ifeq ($(BR2_ENABLE_DEBUG),y) > +define UCLIBC_DEBUG_CONFIG > + $(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config) > +endef > +endif > + > +# > # Endianness > # > > @@ -394,6 +403,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS > $(UCLIBC_SPARC_TYPE_CONFIG) > $(UCLIBC_POWERPC_TYPE_CONFIG) > $(UCLIBC_X86_TYPE_CONFIG) > + $(UCLIBC_DEBUG_CONFIG) > $(UCLIBC_ENDIAN_CONFIG) > $(UCLIBC_LARGEFILE_CONFIG) > $(UCLIBC_IPV6_CONFIG) >
Hello, On Thu, 12 May 2016 20:25:04 +0200, Peter Seiderer wrote: > # > +# Debug > +# > +ifeq ($(BR2_ENABLE_DEBUG),y) > +define UCLIBC_DEBUG_CONFIG > + $(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config) Has this patch really been tested? Inded, I think this line should be: $(call KCONFIG_ENABLE_OPT,DODEBUG,$(@D)/.config) Indeed, setting =y is done by KCONFIG_ENABLE_OPT. It is worth mentioning that we used to do exactly this (setting DODEBUG=y when BR2_ENABLE_DEBUG=y), but removed that in commit 70b7079d3797304fe3c9ba2941d3f446af3cea79in December 2013 because DODEBUG=y was breaking the build. But since then, uClibc has been replaced by uClibc-ng and I guess Waldemar has fixed DODEBUG=y. Peter, did you do a test build on ARM, to verify that you're not falling into the issue mentioned in commit 70b7079d3797304fe3c9ba2941d3f446af3cea79 ? In any case, please resend an updated version with the =y removed. I normally do such minor fixups myself when applying, but in this case, I really want to be sure that you have done a test build. Thanks! Thomas
diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index b8ccee2..d68385d 100644 --- a/package/uclibc/uclibc.mk +++ b/package/uclibc/uclibc.mk @@ -182,6 +182,15 @@ endef endif # +# Debug +# +ifeq ($(BR2_ENABLE_DEBUG),y) +define UCLIBC_DEBUG_CONFIG + $(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config) +endef +endif + +# # Endianness # @@ -394,6 +403,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS $(UCLIBC_SPARC_TYPE_CONFIG) $(UCLIBC_POWERPC_TYPE_CONFIG) $(UCLIBC_X86_TYPE_CONFIG) + $(UCLIBC_DEBUG_CONFIG) $(UCLIBC_ENDIAN_CONFIG) $(UCLIBC_LARGEFILE_CONFIG) $(UCLIBC_IPV6_CONFIG)
Set uclibc DODEBUG in case BR2_ENABLE_DEBUG is set. Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/uclibc/uclibc.mk | 10 ++++++++++ 1 file changed, 10 insertions(+)