Patchwork ide: remove unnecessary blk_queue_flushing() test in do_ide_request()

login
register
mail settings
Submitter Tejun Heo
Date Aug. 19, 2010, 1:35 p.m.
Message ID <4C6D3329.7030901@kernel.org>
Download mbox | patch
Permalink /patch/62158/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - Aug. 19, 2010, 1:35 p.m.
Unplugging from a request function doesn't really help much (it's
already in the request_fn) and soon block layer will be updated to mix
barrier sequence with other commands, so there's no need to treat
queue flushing any differently.

ide was the only user of blk_queue_flushing().  Remove it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
---
David, can I route this patch through block tree with other barrier
changes?

Thanks.

 drivers/ide/ide-io.c   |   13 -------------
 include/linux/blkdev.h |    1 -
 2 files changed, 14 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Aug. 20, 2010, 5:31 p.m.
From: Tejun Heo <tj@kernel.org>
Date: Thu, 19 Aug 2010 15:35:37 +0200

> Unplugging from a request function doesn't really help much (it's
> already in the request_fn) and soon block layer will be updated to mix
> barrier sequence with other commands, so there's no need to treat
> queue flushing any differently.
> 
> ide was the only user of blk_queue_flushing().  Remove it.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
> David, can I route this patch through block tree with other barrier
> changes?

Sure:

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: block/drivers/ide/ide-io.c
===================================================================
--- block.orig/drivers/ide/ide-io.c
+++ block/drivers/ide/ide-io.c
@@ -441,19 +441,6 @@  void do_ide_request(struct request_queue
 	struct request	*rq = NULL;
 	ide_startstop_t	startstop;

-	/*
-	 * drive is doing pre-flush, ordered write, post-flush sequence. even
-	 * though that is 3 requests, it must be seen as a single transaction.
-	 * we must not preempt this drive until that is complete
-	 */
-	if (blk_queue_flushing(q))
-		/*
-		 * small race where queue could get replugged during
-		 * the 3-request flush cycle, just yank the plug since
-		 * we want it to finish asap
-		 */
-		blk_remove_plug(q);
-
 	spin_unlock_irq(q->queue_lock);

 	/* HLD do_request() callback might sleep, make sure it's okay */
Index: block/include/linux/blkdev.h
===================================================================
--- block.orig/include/linux/blkdev.h
+++ block/include/linux/blkdev.h
@@ -520,7 +520,6 @@  enum {
 #define blk_queue_nonrot(q)	test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags)
 #define blk_queue_io_stat(q)	test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags)
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
-#define blk_queue_flushing(q)	((q)->ordseq)
 #define blk_queue_stackable(q)	\
 	test_bit(QUEUE_FLAG_STACKABLE, &(q)->queue_flags)
 #define blk_queue_discard(q)	test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags)