| Submitter | Gerd Hoffmann |
|---|---|
| Date | Aug. 19, 2010, 12:40 p.m. |
| Message ID | <1282221625-29501-3-git-send-email-kraxel@redhat.com> |
| Download | mbox | patch |
| Permalink | /patch/62143/ |
| State | New |
| Headers | show |
Comments
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: > Write compile commands and messages to config.log. > Useful for debugging configure. > > Signed-off-by: Gerd Hoffmann<kraxel@redhat.com> > Indeed. Acked-by: Anthony Liguori <aliguori@us.ibm.com> Given the large nature of spice, I suggest that you setup a subtree for it and do a pull request when the first round is ready. Regards, Anthony Liguori > --- > configure | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index a20371c..13d8be0 100755 > --- a/configure > +++ b/configure > @@ -16,15 +16,18 @@ TMPO="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.o" > TMPE="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.exe" > > trap "rm -f $TMPC $TMPO $TMPE ; exit" EXIT INT QUIT TERM > +rm -f config.log > > compile_object() { > - $cc $QEMU_CFLAGS -c -o $TMPO $TMPC> /dev/null 2> /dev/null > + echo $cc $QEMU_CFLAGS -c -o $TMPO $TMPC>> config.log > + $cc $QEMU_CFLAGS -c -o $TMPO $TMPC>> config.log 2>&1 > } > > compile_prog() { > local_cflags="$1" > local_ldflags="$2" > - $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags> /dev/null 2> /dev/null > + echo $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags>> config.log > + $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags>> config.log 2>&1 > } > > # check whether a command is available to this shell (may be either an >
On 08/19/10 16:05, Anthony Liguori wrote: > On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: >> Write compile commands and messages to config.log. >> Useful for debugging configure. >> >> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com> > > Indeed. > > Acked-by: Anthony Liguori <aliguori@us.ibm.com> > > Given the large nature of spice, I suggest that you setup a subtree for > it and do a pull request when the first round is ready. There *is* a git tree (referenced in the cover letter) to pull from. Will do that for the next version too ;) cheers, Gerd
Patch
diff --git a/configure b/configure index a20371c..13d8be0 100755 --- a/configure +++ b/configure @@ -16,15 +16,18 @@ TMPO="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.o" TMPE="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.exe" trap "rm -f $TMPC $TMPO $TMPE ; exit" EXIT INT QUIT TERM +rm -f config.log compile_object() { - $cc $QEMU_CFLAGS -c -o $TMPO $TMPC > /dev/null 2> /dev/null + echo $cc $QEMU_CFLAGS -c -o $TMPO $TMPC >> config.log + $cc $QEMU_CFLAGS -c -o $TMPO $TMPC >> config.log 2>&1 } compile_prog() { local_cflags="$1" local_ldflags="$2" - $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags > /dev/null 2> /dev/null + echo $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags >> config.log + $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags >> config.log 2>&1 } # check whether a command is available to this shell (may be either an
Write compile commands and messages to config.log. Useful for debugging configure. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- configure | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)