| Message ID | 1462997636-1049487-1-git-send-email-arnd@arndb.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Arnd, On mer., mai 11 2016, Arnd Bergmann <arnd@arndb.de> wrote: > I tried to fix this before, but my previous fix was incomplete > and we can still get the same link error in randconfig builds > because of the way that Kconfig treats the > > default y if MVNETA=y && MVNETA_BM_ENABLE > > line that does not actually trigger when MVNETA_BM_ENABLE=m, > unlike I intended. > Changing the line to use MVNETA_BM_ENABLE!=n however has > the desired effect and hopefully makes all configurations > work as expected. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies") It looks ok for me. Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > --- > drivers/net/ethernet/marvell/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig > index b5c6d42daa12..2664827ddecd 100644 > --- a/drivers/net/ethernet/marvell/Kconfig > +++ b/drivers/net/ethernet/marvell/Kconfig > @@ -68,7 +68,7 @@ config MVNETA > > config MVNETA_BM > tristate > - default y if MVNETA=y && MVNETA_BM_ENABLE > + default y if MVNETA=y && MVNETA_BM_ENABLE!=n > default MVNETA_BM_ENABLE > select HWBM > help > -- > 2.7.0 >
From: Arnd Bergmann <arnd@arndb.de> Date: Wed, 11 May 2016 22:13:23 +0200 > I tried to fix this before, but my previous fix was incomplete > and we can still get the same link error in randconfig builds > because of the way that Kconfig treats the > > default y if MVNETA=y && MVNETA_BM_ENABLE > > line that does not actually trigger when MVNETA_BM_ENABLE=m, > unlike I intended. > Changing the line to use MVNETA_BM_ENABLE!=n however has > the desired effect and hopefully makes all configurations > work as expected. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies") Applied.
diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig index b5c6d42daa12..2664827ddecd 100644 --- a/drivers/net/ethernet/marvell/Kconfig +++ b/drivers/net/ethernet/marvell/Kconfig @@ -68,7 +68,7 @@ config MVNETA config MVNETA_BM tristate - default y if MVNETA=y && MVNETA_BM_ENABLE + default y if MVNETA=y && MVNETA_BM_ENABLE!=n default MVNETA_BM_ENABLE select HWBM help
I tried to fix this before, but my previous fix was incomplete and we can still get the same link error in randconfig builds because of the way that Kconfig treats the default y if MVNETA=y && MVNETA_BM_ENABLE line that does not actually trigger when MVNETA_BM_ENABLE=m, unlike I intended. Changing the line to use MVNETA_BM_ENABLE!=n however has the desired effect and hopefully makes all configurations work as expected. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies") --- drivers/net/ethernet/marvell/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)