diff mbox

[RFC] netxen: remove firmware exports

Message ID 99737F4847ED0A48AECC9F4A1974A4B80F86E69208@MNEXMB2.qlogic.org
State RFC, archived
Delegated to: David Miller
Headers show

Commit Message

amit salecha Aug. 19, 2010, 9:12 a.m. UTC 
> netxen_nic driver can store firmwares on flash, and get them porperly and
> dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
> still exports these firmwares via modinfo, this makes our script which parses
> modinfo output fail.

NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.

> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);

It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE).
I am leaving this upto David to decide about this patch.

-Amit

-----Original Message-----
From: Amerigo Wang [mailto:amwang@redhat.com] 
Sent: Wednesday, August 18, 2010 3:25 PM
To: linux-kernel@vger.kernel.org
Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang
Subject: [RFC Patch] netxen: remove firmware exports


netxen_nic driver can store firmwares on flash, and get them porperly and
dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
still exports these firmwares via modinfo, this makes our script which parses
modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other
modules in a stardand way. I think we can just remove these exports, but
I am not sure.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: Narender Kumar <narender.kumar@qlogic.com>

---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Amerigo Wang Aug. 20, 2010, 8:52 a.m. UTC | #1 
On 08/19/10 17:12, Amit Salecha wrote:
>> netxen_nic driver can store firmwares on flash, and get them porperly and
>> dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
>> still exports these firmwares via modinfo, this makes our script which parses
>> modinfo output fail.
>
> NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.
>
>> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
>
> It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE).
> I am leaving this upto David to decide about this patch.
>

Okay. David, do you want me to submit an updated patch?

Thanks!
amit salecha Aug. 20, 2010, 8:53 a.m. UTC | #2 
> Okay. David, do you want me to submit an updated patch?

You have to submit updated patch.

-Amit

> -----Original Message-----
> From: Cong Wang [mailto:amwang@redhat.com]
> Sent: Friday, August 20, 2010 2:22 PM
> To: Amit Salecha
> Cc: linux-kernel@vger.kernel.org; David S. Miller; Dhananjay Phadke;
> Narender Kumar; netdev@vger.kernel.org
> Subject: Re: [RFC Patch] netxen: remove firmware exports
> 
> On 08/19/10 17:12, Amit Salecha wrote:
> >> netxen_nic driver can store firmwares on flash, and get them
> porperly and
> >> dynamically, so the firmwares may not appear in /lib/firmware/.
> However, netxen_nic
> >> still exports these firmwares via modinfo, this makes our script
> which parses
> >> modinfo output fail.
> >
> > NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we
> won't submit any other fw files.
> >
> >> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
> >
> > It's not compulsory to submit firmware files which are exported
> (MODULE_FIRMWARE).
> > I am leaving this upto David to decide about this patch.
> >
> 
> Okay. David, do you want me to submit an updated patch?
> 
> Thanks!
> 
> --
> The opposite of love is not hate, it's indifference.
>   - Elie Wiesel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..e8443af 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,10 +41,6 @@ 
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"