diff mbox

[ARM/AArch64,04/11] Add forgotten vsliq_n_u64 test.

Message ID 1462973041-7911-5-git-send-email-christophe.lyon@linaro.org
State New
Headers show

Commit Message

Christophe Lyon May 11, 2016, 1:23 p.m. UTC 
2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>

	* gcc.target/aarch64/advsimd-intrinsics/vsli_n.c: Add check for vsliq_n_u64.

Change-Id: I90bb2b225ffd7bfd54a0827a0264ac20271f54f2

Comments

James Greenhalgh May 13, 2016, 2:08 p.m. UTC | #1 
On Wed, May 11, 2016 at 03:23:54PM +0200, Christophe Lyon wrote:
> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	* gcc.target/aarch64/advsimd-intrinsics/vsli_n.c: Add check for vsliq_n_u64.
> 

And vsliq_n_s64 ?

OK with that change.

Thanks,
James

> Change-Id: I90bb2b225ffd7bfd54a0827a0264ac20271f54f2
> 
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
> index 0285083..e5f78d0 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
> @@ -169,6 +169,7 @@ void vsli_extra(void)
>    CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_max_shift, COMMENT);
>    CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_max_shift, COMMENT);
>    CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected_max_shift, COMMENT);
> +  CHECK(TEST_MSG, uint, 64, 2, PRIx64, expected_max_shift, COMMENT);
>    CHECK(TEST_MSG, poly, 8, 16, PRIx8, expected_max_shift, COMMENT);
>    CHECK(TEST_MSG, poly, 16, 8, PRIx16, expected_max_shift, COMMENT);
>  }
> -- 
> 1.9.1
>
Christophe Lyon May 13, 2016, 2:22 p.m. UTC | #2 
On 13 May 2016 at 16:08, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> On Wed, May 11, 2016 at 03:23:54PM +0200, Christophe Lyon wrote:
>> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
>>
>>       * gcc.target/aarch64/advsimd-intrinsics/vsli_n.c: Add check for vsliq_n_u64.
>>
>
> And vsliq_n_s64 ?
>
Damn! You are right, I missed that one.

> OK with that change.
OK thanks

> Thanks,
> James
>
>> Change-Id: I90bb2b225ffd7bfd54a0827a0264ac20271f54f2
>>
>> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>> index 0285083..e5f78d0 100644
>> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>> @@ -169,6 +169,7 @@ void vsli_extra(void)
>>    CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_max_shift, COMMENT);
>>    CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_max_shift, COMMENT);
>>    CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected_max_shift, COMMENT);
>> +  CHECK(TEST_MSG, uint, 64, 2, PRIx64, expected_max_shift, COMMENT);
>>    CHECK(TEST_MSG, poly, 8, 16, PRIx8, expected_max_shift, COMMENT);
>>    CHECK(TEST_MSG, poly, 16, 8, PRIx16, expected_max_shift, COMMENT);
>>  }
>> --
>> 1.9.1
>>
>
Kyrill Tkachov May 16, 2016, 1:27 p.m. UTC | #3 
On 13/05/16 15:22, Christophe Lyon wrote:
> On 13 May 2016 at 16:08, James Greenhalgh <james.greenhalgh@arm.com> wrote:
>> On Wed, May 11, 2016 at 03:23:54PM +0200, Christophe Lyon wrote:
>>> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
>>>
>>>        * gcc.target/aarch64/advsimd-intrinsics/vsli_n.c: Add check for vsliq_n_u64.
>>>
>> And vsliq_n_s64 ?
>>
> Damn! You are right, I missed that one.
>
>> OK with that change.
> OK thanks
>

Ok by me too with that change.

Thanks,
Kyrill

>> Thanks,
>> James
>>
>>> Change-Id: I90bb2b225ffd7bfd54a0827a0264ac20271f54f2
>>>
>>> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>>> index 0285083..e5f78d0 100644
>>> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>>> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
>>> @@ -169,6 +169,7 @@ void vsli_extra(void)
>>>     CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_max_shift, COMMENT);
>>>     CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_max_shift, COMMENT);
>>>     CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected_max_shift, COMMENT);
>>> +  CHECK(TEST_MSG, uint, 64, 2, PRIx64, expected_max_shift, COMMENT);
>>>     CHECK(TEST_MSG, poly, 8, 16, PRIx8, expected_max_shift, COMMENT);
>>>     CHECK(TEST_MSG, poly, 16, 8, PRIx16, expected_max_shift, COMMENT);
>>>   }
>>> --
>>> 1.9.1
>>>
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
index 0285083..e5f78d0 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vsli_n.c
@@ -169,6 +169,7 @@  void vsli_extra(void)
   CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_max_shift, COMMENT);
   CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_max_shift, COMMENT);
   CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected_max_shift, COMMENT);
+  CHECK(TEST_MSG, uint, 64, 2, PRIx64, expected_max_shift, COMMENT);
   CHECK(TEST_MSG, poly, 8, 16, PRIx8, expected_max_shift, COMMENT);
   CHECK(TEST_MSG, poly, 16, 8, PRIx16, expected_max_shift, COMMENT);
 }