| Message ID | 1462859517-30207-1-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 05/10/2016 01:51 AM, Gerd Hoffmann wrote: > Hi, > > First UI pull request for 2.7. Brings a bunch of build tweaks for gtk > and sdl. Fixes the gtk 3.20 deprication warnings. Some stuff piled > up during the freeze. > Only fixes _some_ of the gtk deprecation warnings, the remaining chunk looked a bit more invasive Thanks, Cole
On 10 May 2016 at 06:51, Gerd Hoffmann <kraxel@redhat.com> wrote: > Hi, > > First UI pull request for 2.7. Brings a bunch of build tweaks for gtk > and sdl. Fixes the gtk 3.20 deprication warnings. Some stuff piled > up during the freeze. > > please pull, > Gerd > > The following changes since commit 975eb6a547f809608ccb08c221552f666611af25: > > Update version for v2.6.0-rc4 release (2016-05-02 17:27:01 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-ui-20160510-1 > > for you to fetch changes up to da2e1221d7d19f2506fb04eca255a4fee4fc5f6b: > > spice/gl: add & use qemu_spice_gl_monitor_config (2016-05-10 07:43:46 +0200) > > ---------------------------------------------------------------- > gtk/sdl build tweaks > fix gtk 3.20 warnings > gtk clipboard support > spice-gl monitor config support Commiserations on the first failed-to-build pullreq of the 2.7 cycle: /home/pm215/qemu/ui/gtk.c: In function ‘gd_menu_copy’: /home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable ‘vc’ [-Werror=unused-variable] VirtualConsole *vc = gd_vc_find_current(s); ^ This was on ppc64be Linux, though I'm guessing that's just because it's the only system that happens not to define CONFIG_VTE. (Q: should we even put the "Copy" entry into the menu if we can't actually support copying text ?) thanks -- PMM
> Commiserations on the first failed-to-build pullreq of the 2.7 cycle: > > /home/pm215/qemu/ui/gtk.c: In function ‘gd_menu_copy’: > /home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable ‘vc’ > [-Werror=unused-variable] > VirtualConsole *vc = gd_vc_find_current(s); > ^ > > This was on ppc64be Linux, though I'm guessing that's just because > it's the only system that happens not to define CONFIG_VTE. mingw builds don't have vte too, so I'm wondering now how that one managed to escape my attention ... > (Q: should we even put the "Copy" entry into the menu if we can't > actually support copying text ?) I was trying to not clutter up the patch with too many #ifdef CONFIG_VTE. But, yes, probably we should just #ifdef the whole function and and not add the menu entry. cheers, Gerd
Hi, > > This was on ppc64be Linux, though I'm guessing that's just because > > it's the only system that happens not to define CONFIG_VTE. > > mingw builds don't have vte too, so I'm wondering now how that one > managed to escape my attention ... Ah, because only linux builds default to -Werror. Maybe we should change that? mingw builds without warnings these days for me (which wasn't the case a while ago, which in turn is probably the reason for the selective -Werror). cheers, Gerd
On 13 May 2016 at 08:56, Gerd Hoffmann <kraxel@redhat.com> wrote: >> > This was on ppc64be Linux, though I'm guessing that's just because >> > it's the only system that happens not to define CONFIG_VTE. >> >> mingw builds don't have vte too, so I'm wondering now how that one >> managed to escape my attention ... > > Ah, because only linux builds default to -Werror. > > Maybe we should change that? mingw builds without warnings these days > for me (which wasn't the case a while ago, which in turn is probably the > reason for the selective -Werror). It depends a bit on your config (I have to add -Wno-unused-local-typedefs to work around a glib header warning), but yes, arguably we should (my pre-merge build configs for w32 do use -Werror). thanks -- PMM
Hi, First UI pull request for 2.7. Brings a bunch of build tweaks for gtk and sdl. Fixes the gtk 3.20 deprication warnings. Some stuff piled up during the freeze. please pull, Gerd The following changes since commit 975eb6a547f809608ccb08c221552f666611af25: Update version for v2.6.0-rc4 release (2016-05-02 17:27:01 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20160510-1 for you to fetch changes up to da2e1221d7d19f2506fb04eca255a4fee4fc5f6b: spice/gl: add & use qemu_spice_gl_monitor_config (2016-05-10 07:43:46 +0200) ---------------------------------------------------------------- gtk/sdl build tweaks fix gtk 3.20 warnings gtk clipboard support spice-gl monitor config support ---------------------------------------------------------------- Cole Robinson (10): ui: gtk: fix crash when terminal inner-border is NULL ui: sdl2: Release grab before opening console window configure: build SDL if only SDL2 available configure: error on unknown --with-sdlabi value configure: add echo_version helper configure: report GTK version configure: report SDL version configure: support vte-2.91 ui: gtk: Fix a runtime warning on vte >= 0.37 ui: gtk: Fix some deprecation warnings Gerd Hoffmann (1): spice/gl: add & use qemu_spice_gl_monitor_config Michael S. Tsirkin (1): ui/gtk: copy to clipboard support configure | 62 +++++++++++++++++++++++++++++----------------- include/ui/spice-display.h | 1 + ui/gtk.c | 59 ++++++++++++++++++++++++++++++++++--------- ui/sdl2.c | 4 +++ ui/spice-display.c | 30 ++++++++++++++++++++++ 5 files changed, 121 insertions(+), 35 deletions(-)