Patchwork [Libjava] modify libgcc spec rather than lib.

login
register
mail settings
Submitter IainS
Date Aug. 18, 2010, 9:34 a.m.
Message ID <5154B65D-16F5-410C-8E38-23D8CCA50DC7@sandoe-acoustics.co.uk>
Download mbox | patch
Permalink /patch/62016/
State New
Headers show

Comments

IainS - Aug. 18, 2010, 9:34 a.m.
While we're looking at library ordering,

on darwin we use %G %L - rather than the more usual %L %G %L.

It strikes me that the following spec would be cleaner for both cases,
what do you think?
Iain



@LIBICONV@ @GCSPEC@ @THREADSPEC@ @SYSTEMSPEC@ @LIBSTDCXXSPEC@  
@ZLIBSPEC@  %(liborig)

  *jc1: @HASH_SYNC_SPEC@ @DIVIDESPEC@ @CHECKREFSPEC@ @JC1GCSPEC@  
@EXCEPTIONSPEC@ @BACKTRACESPEC@ @IEEESPEC@ @ATOMICSPEC@  
@LIBGCJ_BC_SPEC@ -fkeep-inline-functions
Andrew Haley - Aug. 18, 2010, 9:44 a.m.
On 08/18/2010 10:34 AM, IainS wrote:
> While we're looking at library ordering,
> 
> on darwin we use %G %L - rather than the more usual %L %G %L.
> 
> It strikes me that the following spec would be cleaner for both cases,
> what do you think?

What's this for?  Where has -lm gone?

Andrew.


> 
> Index: libjava/libgcj.spec.in
> ===================================================================
> --- libjava/libgcj.spec.in    (revision 163330)
> +++ libjava/libgcj.spec.in    (working copy)
> @@ -6,7 +6,7 @@
>  %rename startfile startfileorig
>  *startfile: @THREADSTARTFILESPEC@ %(startfileorig)
> 
> -%rename lib liborig
> -*lib: @LD_START_STATIC_SPEC@ @LIBGCJ_SPEC@ @LD_FINISH_STATIC_SPEC@ -lm @LIBICONV@ @GCSPEC@ @THREADSPEC@ @ZLIBSPEC@ @SYSTEMSPEC@ %(libgcc) @LIBSTDCXXSPEC@ %(liborig)
> +%rename libgcc liborig
> +*libgcc: @LD_START_STATIC_SPEC@ @LIBGCJ_SPEC@ @LD_FINISH_STATIC_SPEC@ @LIBICONV@ @GCSPEC@ @THREADSPEC@ @SYSTEMSPEC@ @LIBSTDCXXSPEC@ @ZLIBSPEC@  %(liborig)
> 
>  *jc1: @HASH_SYNC_SPEC@ @DIVIDESPEC@ @CHECKREFSPEC@ @JC1GCSPEC@ @EXCEPTIONSPEC@ @BACKTRACESPEC@ @IEEESPEC@ @ATOMICSPEC@ @LIBGCJ_BC_SPEC@ -fkeep-inline-functions
>

Patch

Index: libjava/libgcj.spec.in
===================================================================
--- libjava/libgcj.spec.in	(revision 163330)
+++ libjava/libgcj.spec.in	(working copy)
@@ -6,7 +6,7 @@ 
  %rename startfile startfileorig
  *startfile: @THREADSTARTFILESPEC@ %(startfileorig)

-%rename lib liborig
-*lib: @LD_START_STATIC_SPEC@ @LIBGCJ_SPEC@ @LD_FINISH_STATIC_SPEC@ - 
lm @LIBICONV@ @GCSPEC@ @THREADSPEC@ @ZLIBSPEC@ @SYSTEMSPEC@ %(libgcc)  
@LIBSTDCXXSPEC@ %(liborig)
+%rename libgcc liborig
+*libgcc: @LD_START_STATIC_SPEC@ @LIBGCJ_SPEC@ @LD_FINISH_STATIC_SPEC@