Patchwork [1/2] netxen: fix inconsistent lock state

login
register
mail settings
Submitter amit salecha
Date Aug. 18, 2010, 6:51 a.m.
Message ID <1282114312-23500-1-git-send-email-amit.salecha@qlogic.com>
Download mbox | patch
Permalink /patch/62002/
State Accepted
Delegated to: David Miller
Headers show

Comments

amit salecha - Aug. 18, 2010, 6:51 a.m.
Spin lock rds_ring->lock is used in poll routine, so other users should
use spin_lock_bh(). While posting rx buffers from netxen_nic_attach,
rds_ring->lock is not required, so cleaning it instead of fixing it by
spin_lock_bh().

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
---
 drivers/net/netxen/netxen_nic_init.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
David Miller - Aug. 19, 2010, 7:28 a.m.
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 17 Aug 2010 23:51:51 -0700

> Spin lock rds_ring->lock is used in poll routine, so other users should
> use spin_lock_bh(). While posting rx buffers from netxen_nic_attach,
> rds_ring->lock is not required, so cleaning it instead of fixing it by
> spin_lock_bh().
> 
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index c865dda..cabae7b 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -1805,8 +1805,6 @@  netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
 	netxen_ctx_msg msg = 0;
 	struct list_head *head;
 
-	spin_lock(&rds_ring->lock);
-
 	producer = rds_ring->producer;
 
 	head = &rds_ring->free_list;
@@ -1853,8 +1851,6 @@  netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
 					NETXEN_RCV_PRODUCER_OFFSET), msg);
 		}
 	}
-
-	spin_unlock(&rds_ring->lock);
 }
 
 static void