Message ID | 57305AE7.7050607@ubuntu.com |
---|---|
State | New |
Headers | show |
On Mon, May 09, 2016 at 11:39:51 +0200, Matthias Klose wrote: > >well, it breaks the build for many multilib configurations where multilib > >binaries cannot be run on the current environment, e.g. building x32 multilibs > >on a kernel which doesn't have x32 enabled. > > > >The reason is again moving compiler checks (AC_USE_SYSTEM_EXTENSIONS) in the > >configure.ac before the AM_ENABLE_MULTILIB. > > > >So please move the AC_USE_SYSTEM_EXTENSIONS macro behind the AM_ENABLE_MULTILIB, > >and forward this change upstream if applicable. > > > >example build log at > >https://buildd.debian.org/status/fetch.php?pkg=gcc-snapshot&arch=amd64&ver=20160506-1&stamp=1462580913 > > fixed by: > > * configure.ac: Move AC_USE_SYSTEM_EXTENSIONS behind AM_ENABLE_MULTILIB. > * configure: Regenerate. > > --- a/libcilkrts/configure.ac > +++ b/libcilkrts/configure.ac > @@ -51,9 +51,6 @@ > target_alias=${target_alias-$host_alias} > AC_SUBST(target_alias) > > -# Test for GNU extensions. Will define _GNU_SOURCE if they're available > -AC_USE_SYSTEM_EXTENSIONS > - > AM_INIT_AUTOMAKE(foreign no-dist) > > AM_MAINTAINER_MODE > @@ -60,6 +57,9 @@ > > AM_ENABLE_MULTILIB(, ..) > > +# Test for GNU extensions. Will define _GNU_SOURCE if they're available > +AC_USE_SYSTEM_EXTENSIONS > + > # Build a DLL on Windows > # AC_LIBTOOL_WIN32_DLL > AC_PROG_CC Thanks for investigating and fixing this. The patch is pushed upstream. -- Ilya
--- a/libcilkrts/configure.ac +++ b/libcilkrts/configure.ac @@ -51,9 +51,6 @@ target_alias=${target_alias-$host_alias} AC_SUBST(target_alias) -# Test for GNU extensions. Will define _GNU_SOURCE if they're available -AC_USE_SYSTEM_EXTENSIONS - AM_INIT_AUTOMAKE(foreign no-dist) AM_MAINTAINER_MODE @@ -60,6 +57,9 @@ AM_ENABLE_MULTILIB(, ..) +# Test for GNU extensions. Will define _GNU_SOURCE if they're available +AC_USE_SYSTEM_EXTENSIONS + # Build a DLL on Windows # AC_LIBTOOL_WIN32_DLL AC_PROG_CC