diff mbox

[iproute2,1/1] tc fix ife late binding

Message ID 1462721329-27987-1-git-send-email-jhs@emojatatu.com
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Jamal Hadi Salim May 8, 2016, 3:28 p.m. UTC 
From: Jamal Hadi Salim <jhs@mojatatu.com>

following late action binding didn't work:

sudo tc actions add action ife encode \
type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1

sudo tc filter add dev lo parent ffff: protocol ip prio 2 u32\
match ip src 127.0.0.2/32 flowid 1:2 action ife index 1

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/m_ife.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Hemminger May 16, 2016, 6:16 p.m. UTC | #1 
On Sun,  8 May 2016 11:28:49 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> From: Jamal Hadi Salim <jhs@mojatatu.com>
> 
> following late action binding didn't work:
> 
> sudo tc actions add action ife encode \
> type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1
> 
> sudo tc filter add dev lo parent ffff: protocol ip prio 2 u32\
> match ip src 127.0.0.2/32 flowid 1:2 action ife index 1
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Ok, applied all the ife patches (for 4.6)
diff mbox

Patch

diff --git a/tc/m_ife.c b/tc/m_ife.c
index ed01ff7..c8ae04d 100644
--- a/tc/m_ife.c
+++ b/tc/m_ife.c
@@ -182,6 +182,7 @@  static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
 				fprintf(stderr, "ife: Illegal \"index\"\n");
 				return -1;
 			}
+			ok++;
 			argc--;
 			argv++;
 		}