diff mbox

[1/1] package/go: bump version to 1.6.2

Message ID 20160508145944.09f42d02@free-electrons.com
State Not Applicable
Headers show

Commit Message

Thomas Petazzoni May 8, 2016, 12:59 p.m. UTC 
Hello,

On Sun, 8 May 2016 22:46:14 +1000, Cam Hutchison wrote:

> I don't know anything about bootstraping the compiler with anything other
> than go 1.4 - as far as my limited understanding goes, that is still necessary.
> 
> What I meant was that it should not be necessary to backport the patch
> as you suggested, but instead compile the bootstrap compiler with
> CGO_ENABLED=0 in the environment. That worked for me when I
> saw the same problem building the bootstrap compiler (but the problem
> was not consistent and no one else seemed to have it, so I just assumed
> there was an issue in my build environment - so I never posted this
> fix).

Aah, OK! I can indeed confirm that the following patch fixes the build
problem for me.

Geoff, if that's OK for you, could you send a proper patch that does
this?


Thanks!

Thomas

Comments

Geoff Levand May 10, 2016, 5:37 p.m. UTC | #1 
On Sun, 2016-05-08 at 14:59 +0200, Thomas Petazzoni wrote:
> Geoff, if that's OK for you, could you send a proper patch that does
> this?
> 
> diff --git a/package/go-bootstrap/go-bootstrap.mk b/package/go-bootstrap/go-bootstrap.mk
> index e404cb6..2b46694 100644
> --- a/package/go-bootstrap/go-bootstrap.mk
> +++ b/package/go-bootstrap/go-bootstrap.mk
> @@ -17,7 +17,8 @@ HOST_GO_BOOTSTRAP_MAKE_ENV = \
>         GOOS=linux \
>         GOROOT_FINAL="$(HOST_GO_BOOTSTRAP_ROOT)" \
>         GOROOT="$(@D)" \
> -       GOBIN="$(@D)/bin"
> +       GOBIN="$(@D)/bin" \
> +       CGO_ENABLED=0

We do not need cgo support in the bootstrap compiler, so this
should be the correct fix.  I'll test and send out a patch.

-Geoff
diff mbox

Patch

diff --git a/package/go-bootstrap/go-bootstrap.mk b/package/go-bootstrap/go-bootstrap.mk
index e404cb6..2b46694 100644
--- a/package/go-bootstrap/go-bootstrap.mk
+++ b/package/go-bootstrap/go-bootstrap.mk
@@ -17,7 +17,8 @@  HOST_GO_BOOTSTRAP_MAKE_ENV = \
        GOOS=linux \
        GOROOT_FINAL="$(HOST_GO_BOOTSTRAP_ROOT)" \
        GOROOT="$(@D)" \
-       GOBIN="$(@D)/bin"
+       GOBIN="$(@D)/bin" \
+       CGO_ENABLED=0
 
 define HOST_GO_BOOTSTRAP_BUILD_CMDS
        cd $(@D)/src && $(HOST_GO_BOOTSTRAP_MAKE_ENV) ./make.bash