| Message ID | 1462619832-5177-2-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote: > When reopening the network device on ra7795/salvator-x, e.g. after a > DHCP timeout: > > IP-Config: Reopening network devices... > genirq: Flags mismatch irq 139. 00000000 (eth0:ch24:emac) vs. 00000000 (eth0:ch24:emac) > ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch24:emac Er, this can't be a message from the kernel built from net.git. That driver used 'ndev->name' to request both IRQs... > IP-Config: Failed to open eth0 > IP-Config: No network devices available > > The "mismatch" is due to requesting an IRQ that is already in use, > while IRQF_PROBE_SHARED wasn't set. > > However, the real cause is that ravb_close() doesn't release the R-Car > Gen3-specific secondary IRQ. > > Add the missing free_irq() call to fix this. > > Fixes: 22d4df8ff3a3cc72 ("ravb: Add support for r8a7795 SoC") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
On Sat, May 7, 2016 at 8:39 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote: > >> When reopening the network device on ra7795/salvator-x, e.g. after a >> DHCP timeout: >> >> IP-Config: Reopening network devices... >> genirq: Flags mismatch irq 139. 00000000 (eth0:ch24:emac) vs. >> 00000000 (eth0:ch24:emac) >> ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch24:emac > > Er, this can't be a message from the kernel built from net.git. That > driver used 'ndev->name' > to request both IRQs... Oops, I copied the error message from the second patch. I don't think it matters that much, though... >> IP-Config: Failed to open eth0 >> IP-Config: No network devices available >> >> The "mismatch" is due to requesting an IRQ that is already in use, >> while IRQF_PROBE_SHARED wasn't set. >> >> However, the real cause is that ravb_close() doesn't release the R-Car >> Gen3-specific secondary IRQ. >> >> Add the missing free_irq() call to fix this. >> >> Fixes: 22d4df8ff3a3cc72 ("ravb: Add support for r8a7795 SoC") >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 9e2a0bd8f5a88803..4277d0c12101fef7 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1506,6 +1506,8 @@ static int ravb_close(struct net_device *ndev) priv->phydev = NULL; } + if (priv->chip_id == RCAR_GEN3) + free_irq(priv->emac_irq, ndev); free_irq(ndev->irq, ndev); napi_disable(&priv->napi[RAVB_NC]);
When reopening the network device on ra7795/salvator-x, e.g. after a DHCP timeout: IP-Config: Reopening network devices... genirq: Flags mismatch irq 139. 00000000 (eth0:ch24:emac) vs. 00000000 (eth0:ch24:emac) ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch24:emac IP-Config: Failed to open eth0 IP-Config: No network devices available The "mismatch" is due to requesting an IRQ that is already in use, while IRQF_PROBE_SHARED wasn't set. However, the real cause is that ravb_close() doesn't release the R-Car Gen3-specific secondary IRQ. Add the missing free_irq() call to fix this. Fixes: 22d4df8ff3a3cc72 ("ravb: Add support for r8a7795 SoC") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- This version is against net.git. v2: - New. --- drivers/net/ethernet/renesas/ravb_main.c | 2 ++ 1 file changed, 2 insertions(+)