| Message ID | 1462577103-7598-1-git-send-email-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sat, 7 May 2016 01:25:03 +0200, Jörg Krause wrote: > taskd checks for `get_current_dir_name` but forgets to add a `cmakedefine` > in cmake.h.in, so `HAVE_GET_CURRENT_DIR_NAME` is always undefined. > > CMake detects correctly that the musl C library defines `get_current_dir_name`. > However, as `HAVE_GET_CURRENT_DIR_NAME` is not set, the block of code evaluated > cannot be compiled as musl does not define `PATH_MAX`. > > Reported upstream: > https://bug.tasktools.org/browse/TD-120 > > Fixes: > http://autobuild.buildroot.net/results/121/121aa15235e06c80d65428626da5a2da9d11c9ba/ > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Thanks, applied! I saw that you asked why I rejected some of Bernd's patches fixing musl issues, and Arnout answered you. This patch from you is exactly what I expect: a real analysis of the problem, a proper Git formatted patch that has a good explanation other than "fixes musl build" and an issue reported upstream. Simply perfect. Thanks! Thomas
diff --git a/package/taskd/0001-Fix-missing-cmakedefine-HAVE_GET_CURRENT_DIR_NAME.patch b/package/taskd/0001-Fix-missing-cmakedefine-HAVE_GET_CURRENT_DIR_NAME.patch new file mode 100644 index 0000000..960c71b --- /dev/null +++ b/package/taskd/0001-Fix-missing-cmakedefine-HAVE_GET_CURRENT_DIR_NAME.patch @@ -0,0 +1,28 @@ +From b067ab9bf667bb9257bb9eeaa6bf25f9a1a17f06 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks> +Date: Fri, 6 May 2016 23:35:42 +0200 +Subject: [PATCH] Fix missing cmakedefine HAVE_GET_CURRENT_DIR_NAME +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> +--- + cmake.h.in | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/cmake.h.in b/cmake.h.in +index 4124ce9..0b8f9d0 100644 +--- a/cmake.h.in ++++ b/cmake.h.in +@@ -51,6 +51,7 @@ + #cmakedefine HAVE_ST_BIRTHTIME + + /* Functions */ ++#cmakedefine HAVE_GET_CURRENT_DIR_NAME + #cmakedefine HAVE_TIMEGM + #cmakedefine HAVE_UUID_UNPARSE_LOWER + +-- +2.8.2 +
taskd checks for `get_current_dir_name` but forgets to add a `cmakedefine` in cmake.h.in, so `HAVE_GET_CURRENT_DIR_NAME` is always undefined. CMake detects correctly that the musl C library defines `get_current_dir_name`. However, as `HAVE_GET_CURRENT_DIR_NAME` is not set, the block of code evaluated cannot be compiled as musl does not define `PATH_MAX`. Reported upstream: https://bug.tasktools.org/browse/TD-120 Fixes: http://autobuild.buildroot.net/results/121/121aa15235e06c80d65428626da5a2da9d11c9ba/ Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- ...ing-cmakedefine-HAVE_GET_CURRENT_DIR_NAME.patch | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 package/taskd/0001-Fix-missing-cmakedefine-HAVE_GET_CURRENT_DIR_NAME.patch