| Message ID | 1462488064-1841-20-git-send-email-vivien.didelot@savoirfairelinux.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: > 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. > Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all > other mv88e6xxx drivers. Hi Vivien You might as well remove net/dsa/tag_dsa.c as well, since it is now unused. Please do that as a separate patch. Andrew
Hi Andrew, Andrew Lunn <andrew@lunn.ch> writes: > On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: >> 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. >> Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all >> other mv88e6xxx drivers. > > You might as well remove net/dsa/tag_dsa.c as well, since it is now > unused. Please do that as a separate patch. Why not, but isn't it a bit out of the scope of this patchset? Thanks, Vivien
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index 4aaadce..7e01dce 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -17,7 +17,7 @@ config NET_DSA_MV88E6131 tristate "Marvell 88E6085/6095/6095F/6131 ethernet switch chip support" depends on NET_DSA select NET_DSA_MV88E6XXX - select NET_DSA_TAG_DSA + select NET_DSA_TAG_EDSA ---help--- This enables support for the Marvell 88E6085/6095/6095F/6131 ethernet switch chips. diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c index cf7d710..81640f6 100644 --- a/drivers/net/dsa/mv88e6131.c +++ b/drivers/net/dsa/mv88e6131.c @@ -75,7 +75,7 @@ static const char *mv88e6131_drv_probe(struct device *dsa_dev, } struct dsa_switch_driver mv88e6131_switch_driver = { - .tag_protocol = DSA_TAG_PROTO_DSA, + .tag_protocol = DSA_TAG_PROTO_EDSA, .probe = mv88e6131_drv_probe, .setup = mv88e6xxx_setup, .set_addr = mv88e6xxx_set_addr,
6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all other mv88e6xxx drivers. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- drivers/net/dsa/Kconfig | 2 +- drivers/net/dsa/mv88e6131.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)