diff mbox

i2c: qup: use address helper function in read transfer

Message ID 1462473197-28393-1-git-send-email-nkaje@codeaurora.org
State Accepted
Headers show

Commit Message

Naveen Kaje May 5, 2016, 6:33 p.m. UTC 
qup_i2c_issue_read() derives the address from i2c_msg.
This called in the read path when I2C_M_RD flag is set.
Therefore, use the 8 bit address helper function.

Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
---
 drivers/i2c/busses/i2c-qup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang June 18, 2016, 4:31 p.m. UTC | #1 
On Thu, May 05, 2016 at 12:33:17PM -0600, Naveen Kaje wrote:
> qup_i2c_issue_read() derives the address from i2c_msg.
> This called in the read path when I2C_M_RD flag is set.
> Therefore, use the 8 bit address helper function.
> 
> Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>

Applied to for-next, thanks!
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 8082919..072e352 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -1038,7 +1038,7 @@  static void qup_i2c_issue_read(struct qup_i2c_dev *qup, struct i2c_msg *msg)
 {
 	u32 addr, len, val;
 
-	addr = (msg->addr << 1) | 1;
+	addr = i2c_8bit_addr_from_msg(msg);
 
 	/* 0 is used to specify a length 256 (QUP_READ_LIMIT) */
 	len = (msg->len == QUP_READ_LIMIT) ? 0 : msg->len;