diff mbox

[U-Boot,v2,10/18] at91: Correct NAND ECC register access

Message ID 1462454902-6093-11-git-send-email-sjg@chromium.org
State Awaiting Upstream
Delegated to: Andreas Bießmann
Headers show

Commit Message

Simon Glass May 5, 2016, 1:28 p.m. UTC 
From: Andre Renaud <andre@designa-electronics.com>

This uses the wrote base register value. Fix it.

Signed-off-by: Andre Renaud <andre@designa-electronics.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 drivers/mtd/nand/atmel_nand.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Bießmann May 28, 2016, 9:06 p.m. UTC | #1 
On 05.05.16 15:28, Simon Glass wrote:
> From: Andre Renaud <andre@designa-electronics.com>
> 
> This uses the wrote base register value. Fix it.
> 
> Signed-off-by: Andre Renaud <andre@designa-electronics.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Andreas Bießmann <andreas@biessmann.org>
Andreas Bießmann June 12, 2016, 10:01 p.m. UTC | #2 
Dear Simon Glass,

Simon Glass <sjg@chromium.org> writes:
>From: Andre Renaud <andre@designa-electronics.com>
>
>This uses the wrote base register value. Fix it.
>
>Signed-off-by: Andre Renaud <andre@designa-electronics.com>
>Signed-off-by: Simon Glass <sjg@chromium.org>
>Reviewed-by: Andreas Bießmann <andreas@biessmann.org>
>---
>
>Changes in v2: None
>
> drivers/mtd/nand/atmel_nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bießmann
diff mbox

Patch

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 7cc1de0..4e278fa 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -24,9 +24,9 @@ 
 
 /* Register access macros */
 #define ecc_readl(add, reg)				\
-	readl(AT91_BASE_SYS + add + ATMEL_ECC_##reg)
+	readl(add + ATMEL_ECC_##reg)
 #define ecc_writel(add, reg, value)			\
-	writel((value), AT91_BASE_SYS + add + ATMEL_ECC_##reg)
+	writel((value), add + ATMEL_ECC_##reg)
 
 #include "atmel_nand_ecc.h"	/* Hardware ECC registers */