From patchwork Tue Aug 17 04:44:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/4] rtc-bfin: fix inverted logic in suspend path Date: Mon, 16 Aug 2010 18:44:06 -0000 From: Mike Frysinger X-Patchwork-Id: 61853 Message-Id: <1282020249-8807-1-git-send-email-vapier@gentoo.org> To: rtc-linux@googlegroups.com, Alessandro Zummo Cc: uclinux-dist-devel@blackfin.uclinux.org, Andrew Morton The int_clear helper takes a bitmask of interrupts to keep, not to disable. When suspending without wakeup enabled, we want to disable all interrupts, so use 0 (keep none) instead of -1 (keep all). Signed-off-by: Mike Frysinger --- drivers/rtc/rtc-bfin.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index 72b2bcc..65facfb 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -426,7 +426,7 @@ static int bfin_rtc_suspend(struct platform_device *pdev, pm_message_t state) enable_irq_wake(IRQ_RTC); bfin_rtc_sync_pending(&pdev->dev); } else - bfin_rtc_int_clear(-1); + bfin_rtc_int_clear(0); return 0; }