Message ID | 1462308680-9366-6-git-send-email-marex@denx.de |
---|---|
State | Accepted |
Commit | d81db48d418edc30301961781d8a64d7cc109dd4 |
Delegated to: | Marek Vasut |
Headers | show |
On 03.05.2016 22:51, Marek Vasut wrote: > The code shouldn't continue probing the port if get_port_status() failed. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Stefan Roese <sr@denx.de> > Cc: Stephen Warren <swarren@nvidia.com> > --- > common/usb_hub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/usb_hub.c b/common/usb_hub.c > index 4f59802..0f39c9f 100644 > --- a/common/usb_hub.c > +++ b/common/usb_hub.c > @@ -402,6 +402,7 @@ static int usb_scan_port(struct usb_device_scan *usb_scan) > free(usb_scan); > return 0; > } > + return 0; > } > > portstatus = le16_to_cpu(portsts->wPortStatus); > Thanks for spotting this: Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
On Wed, 2016-05-04 at 10:05 +0200, Stefan Roese wrote: > On 03.05.2016 22:51, Marek Vasut wrote: > > The code shouldn't continue probing the port if get_port_status() > > failed. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Hans de Goede <hdegoede@redhat.com> > > Cc: Stefan Roese <sr@denx.de> > > Cc: Stephen Warren <swarren@nvidia.com> > > --- > > common/usb_hub.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/common/usb_hub.c b/common/usb_hub.c > > index 4f59802..0f39c9f 100644 > > --- a/common/usb_hub.c > > +++ b/common/usb_hub.c > > @@ -402,6 +402,7 @@ static int usb_scan_port(struct usb_device_scan > > *usb_scan) > > free(usb_scan); > > return 0; > > } > > + return 0; > > } > > > > portstatus = le16_to_cpu(portsts->wPortStatus); > > > > Thanks for spotting this: > > Reviewed-by: Stefan Roese <sr@denx.de> > Reviewed-by: Chin Liang See <clsee@altera.com> Tested-by: Chin Liang See <clsee@altera.com> Thanks Chin Liang > Thanks, > Stefan
diff --git a/common/usb_hub.c b/common/usb_hub.c index 4f59802..0f39c9f 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -402,6 +402,7 @@ static int usb_scan_port(struct usb_device_scan *usb_scan) free(usb_scan); return 0; } + return 0; } portstatus = le16_to_cpu(portsts->wPortStatus);
The code shouldn't continue probing the port if get_port_status() failed. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Stefan Roese <sr@denx.de> Cc: Stephen Warren <swarren@nvidia.com> --- common/usb_hub.c | 1 + 1 file changed, 1 insertion(+)