Patchwork infiniband: Add struct in6_addr addr to union ib_gib

login
register
mail settings
Submitter Joe Perches
Date Oct. 29, 2008, 12:16 a.m.
Message ID <1225239374.5269.251.camel@localhost>
Download mbox | patch
Permalink /patch/6181/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Joe Perches - Oct. 29, 2008, 12:16 a.m.
ib_gid's can be print'd using the new %p6 facility

Signed-off-by: Joe Perches <joe@perches.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 29, 2008, 5:39 a.m.
From: Joe Perches <joe@perches.com>
Date: Tue, 28 Oct 2008 17:16:14 -0700

> ib_gid's can be print'd using the new %p6 facility
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Joe, please provide something relative to Harvey's patches
so that this new union member gets passed into the %p6
uses.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joe Perches - Oct. 29, 2008, 6:58 a.m.
On Tue, 2008-10-28 at 22:39 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Tue, 28 Oct 2008 17:16:14 -0700
> > ib_gid's can be print'd using the new %p6 facility
> > Signed-off-by: Joe Perches <joe@perches.com>
> Joe, please provide something relative to Harvey's patches
> so that this new union member gets passed into the %p6
> uses.

Sure.  After Harvey's patches show up in
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=summary
I'll make a patchset including this union ib_gid addition as
well as changes to drivers/infiniband/

Roland, in a separate question, are the infiniband maintainers
also the maintainers of include/rdma/?  If "F: patterns" ever
gets accepted into MAINTAINERS, should include/rdma/ be listed
under infiniband?

You and Sean Hefty seem to be the primary authors.

$ git log include/rdma/ | grep Author: | \
  sort | uniq -c | sort -nr | head -5
     32 Author: Sean Hefty <sean.hefty@intel.com>
     23 Author: Roland Dreier <rolandd@cisco.com>
      6 Author: Michael S. Tsirkin <mst@mellanox.co.il>
      5 Author: Or Gerlitz <ogerlitz@voltaire.com>
      4 Author: Jack Morgenstein <jackm@mellanox.co.il>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 29, 2008, 8:39 a.m.
From: Joe Perches <joe@perches.com>
Date: Tue, 28 Oct 2008 23:58:40 -0700

> On Tue, 2008-10-28 at 22:39 -0700, David Miller wrote:
> > From: Joe Perches <joe@perches.com>
> > Date: Tue, 28 Oct 2008 17:16:14 -0700
> > > ib_gid's can be print'd using the new %p6 facility
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > Joe, please provide something relative to Harvey's patches
> > so that this new union member gets passed into the %p6
> > uses.
> 
> Sure.  After Harvey's patches show up in
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=summary

They should be there now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roland Dreier - Oct. 29, 2008, 6:15 p.m.
> Sure.  After Harvey's patches show up in
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=summary
> I'll make a patchset including this union ib_gid addition as
> well as changes to drivers/infiniband/

OK I guess.  I also don't have any objection to using a different
format letter but the
same underlying code as the p6 implementation as an alternative for handling
the type checking.

> Roland, in a separate question, are the infiniband maintainers
> also the maintainers of include/rdma/?  If "F: patterns" ever
> gets accepted into MAINTAINERS, should include/rdma/ be listed
> under infiniband?

Yes, drivers/infiniband and include/rdma are all part of the
InfiniBand/RDMA stack.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 936e333..464ed9d 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -47,6 +47,7 @@ 
 #include <linux/list.h>
 #include <linux/rwsem.h>
 #include <linux/scatterlist.h>
+#include <linux/in6.h>
 
 #include <asm/atomic.h>
 #include <asm/uaccess.h>
@@ -57,6 +58,7 @@  union ib_gid {
 		__be64	subnet_prefix;
 		__be64	interface_id;
 	} global;
+	struct in6_addr	addr;
 };
 
 enum rdma_node_type {