How to enable rtmp support in gst1-plugins-bad?

I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
So, I think that it is a misprint. Is it? Patch looks like:

On 03/05/16 09:14, sonntex wrote:

> I did not find rtmp support in gst1-plugins-bad. There is only rtp
> support. So, I think that it is a misprint. Is it? Patch looks like:

Hi.
This looks accurate, care to resend the patch with a SoB line and a nice 
subject for the patch?
Thanks!
Regards.

Hello sonntex,

On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:

> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
> So, I think that it is a misprint. Is it? Patch looks like:

No misprint, only a missing update  since version bump to 1.8.0.

Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
same with mpg123 support, moved from -bad to -ugly (see [2])...

Time to do a re-check of the options for 1.8.x, but did not yet find the
time for it....

Regards,
Peter

[1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
[2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664

> 
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in
> b/package/gstreamer1/gst1-plugins-bad/Config.in
> index a9667af..afbe2bf 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -382,8 +382,8 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
>         help
>           Removes silence from an audio stream
> 
> -config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
> -       bool "rtp"
> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
> +       bool "rtmp"
> 
>  config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
>         bool "sdi"
> diff --git a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> index a92c4a6..30c4999 100644
> --- a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> +++ b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> @@ -479,10 +479,11 @@ else
>  GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
>  endif
> 
> -ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP),y)
> -GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtp
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP),y)
> +GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtmp
> +GST1_PLUGINS_BAD_DEPENDENCIES += rtmpdump
>  else
> -GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtp
> +GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtmp
>  endif
> 
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)

On 03/05/16 15:46, Peter Seiderer wrote:

> Hello sonntex,
>
> On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:
>
>> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
>> So, I think that it is a misprint. Is it? Patch looks like:
>
> No misprint, only a missing update  since version bump to 1.8.0.
>
> Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
> same with mpg123 support, moved from -bad to -ugly (see [2])...
>
> Time to do a re-check of the options for 1.8.x, but did not yet find the
> time for it....
>
> Regards,
> Peter
>
> [1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
> [2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664

Hi Peter.
Argh, i missed the move, probably because i looked into configure and/or 
NEWS rather than commits/relnotes.
Do you want to pick up these removals, moves and legacy or shall i?
It would be good to have this sorted out for the upcoming release.
Thanks.
Regards.

Hello Gustavo,

On Tue, 3 May 2016 15:55:20 -0300, Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:

> On 03/05/16 15:46, Peter Seiderer wrote:
> 
> > Hello sonntex,
> >
> > On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:
> >
> >> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
> >> So, I think that it is a misprint. Is it? Patch looks like:
> >
> > No misprint, only a missing update  since version bump to 1.8.0.
> >
> > Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
> > same with mpg123 support, moved from -bad to -ugly (see [2])...
> >
> > Time to do a re-check of the options for 1.8.x, but did not yet find the
> > time for it....
> >
> > Regards,
> > Peter
> >
> > [1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
> > [2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664
> 
> Hi Peter.
> Argh, i missed the move, probably because i looked into configure and/or 
> NEWS rather than commits/relnotes.
> Do you want to pick up these removals, moves and legacy or shall i?
> It would be good to have this sorted out for the upcoming release.

No problem (only a little work ;-) ), feel free to pick it up...

Regards,
Peter

> Thanks.
> Regards.