| Message ID | 1281948641.29696.1.camel@mola |
|---|---|
| State | New, archived |
| Headers | show |
Cc'ed Lei and Haojian. On Mon, Aug 16, 2010 at 4:50 PM, Axel Lin <axel.lin@gmail.com> wrote: > This patch adds timing settings for samsung2GbX8 and > fixes the cmdset settings. samsung2GbX8 is large page. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/mtd/nand/pxa3xx_nand.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 4d89f37..47c0442 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -227,9 +227,21 @@ static struct pxa3xx_nand_flash samsung512MbX16 = { > .chip_id = 0x46ec, > }; > > +static struct pxa3xx_nand_timing samsung2GbX8_timing = { > + .tCH = 5, > + .tCS = 20, > + .tWH = 10, > + .tWP = 12, > + .tRH = 10, > + .tRP = 12, > + .tR = 25000, > + .tWHR = 60, > + .tAR = 10, > +}; > + > static struct pxa3xx_nand_flash samsung2GbX8 = { > - .timing = &samsung512MbX16_timing, > - .cmdset = &smallpage_cmdset, > + .timing = &samsung2GbX8_timing, > + .cmdset = &largepage_cmdset, > .page_per_block = 64, > .page_size = 2048, > .flash_width = 8, > -- > 1.7.2 > > > >
Hi Axel, I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed. Thanks, Lei -----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 20:22 To: Axel Lin Cc: linux-kernel; David Woodhouse; linux-mtd@lists.infradead.org; Lei Wen; Haojian Zhuang Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 Cc'ed Lei and Haojian. On Mon, Aug 16, 2010 at 4:50 PM, Axel Lin <axel.lin@gmail.com> wrote: > This patch adds timing settings for samsung2GbX8 and > fixes the cmdset settings. samsung2GbX8 is large page. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/mtd/nand/pxa3xx_nand.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 4d89f37..47c0442 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -227,9 +227,21 @@ static struct pxa3xx_nand_flash samsung512MbX16 = { > .chip_id = 0x46ec, > }; > > +static struct pxa3xx_nand_timing samsung2GbX8_timing = { > + .tCH = 5, > + .tCS = 20, > + .tWH = 10, > + .tWP = 12, > + .tRH = 10, > + .tRP = 12, > + .tR = 25000, > + .tWHR = 60, > + .tAR = 10, > +}; > + > static struct pxa3xx_nand_flash samsung2GbX8 = { > - .timing = &samsung512MbX16_timing, > - .cmdset = &smallpage_cmdset, > + .timing = &samsung2GbX8_timing, > + .cmdset = &largepage_cmdset, > .page_per_block = 64, > .page_size = 2048, > .flash_width = 8, > -- > 1.7.2 > > > >
On Mon, Aug 16, 2010 at 8:34 PM, Lei Wen <leiwen@marvell.com> wrote: > Hi Axel, > > I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed. > Lei, would you please point the URL of the patch series (possibly by searching linux-mtd archive or some other mailing list archive) so that Axel can have a reference and be involved? - eric
http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. By the way, David, what's the result of review on these patches? We already posted for several times. Thanks Haojian -----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 8:44 PM To: Lei Wen Cc: Axel Lin; linux-kernel; David Woodhouse; linux-mtd@lists.infradead.org; Haojian Zhuang Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 On Mon, Aug 16, 2010 at 8:34 PM, Lei Wen <leiwen@marvell.com> wrote: > Hi Axel, > > I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed. > Lei, would you please point the URL of the patch series (possibly by searching linux-mtd archive or some other mailing list archive) so that Axel can have a reference and be involved? - eric
On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote: > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html > > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. > > By the way, David, what's the result of review on these patches? We already posted for several times. > I've actually reviewed some of the patches and gave my Ack. For those patches, I think they can be merged early. And overall, they look good. Yet 29 patch in a whole is still a bit too much, would be good to see them logically be separated into several patch series. > Thanks > Haojian > > -----Original Message----- > From: Eric Miao [mailto:eric.y.miao@gmail.com] > Sent: 2010年8月16日 8:44 PM > To: Lei Wen > Cc: Axel Lin; linux-kernel; David Woodhouse; linux-mtd@lists.infradead.org; Haojian Zhuang > Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 > > On Mon, Aug 16, 2010 at 8:34 PM, Lei Wen <leiwen@marvell.com> wrote: >> Hi Axel, >> >> I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed. >> > > Lei, would you please point the URL of the patch series (possibly by > searching linux-mtd archive or some other mailing list archive) so that > Axel can have a reference and be involved? > > - eric >
On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote: > On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote: > > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html > > > > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. > > > > By the way, David, what's the result of review on these patches? We already posted for several times. > > > > I've actually reviewed some of the patches and gave my Ack. For those > patches, I think they can be merged early. > > And overall, they look good. Yet 29 patch in a whole is still a bit too > much, would be good to see them logically be separated into several > patch series. You had some criticism of patch #1 in the sequence, and some questions. I didn't look much harder than that, iirc... although looking back now it seems that the rest of your responses to the sequence were largely positive. Are you happy with the first patch, and if so shall I go ahead and import the whole sequence with your Acked-By:?
On Mon, Aug 16, 2010 at 9:05 PM, David Woodhouse <dwmw2@infradead.org> wrote: > On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote: >> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote: >> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html >> > >> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. >> > >> > By the way, David, what's the result of review on these patches? We already posted for several times. >> > >> >> I've actually reviewed some of the patches and gave my Ack. For those >> patches, I think they can be merged early. >> >> And overall, they look good. Yet 29 patch in a whole is still a bit too >> much, would be good to see them logically be separated into several >> patch series. > > You had some criticism of patch #1 in the sequence, and some questions. > So they need to be addressed. Lei, could you please come up with an updated patch? > I didn't look much harder than that, iirc... although looking back now > it seems that the rest of your responses to the sequence were largely > positive. > > Are you happy with the first patch, and if so shall I go ahead and > import the whole sequence with your Acked-By:? > I'm generally OK, but still think it would be good to have another around of review before they can be merged.
Eric, The first patch is a bit of fundamental. I'm afraid that modify it would bring changes to all latter patches in this series... So I think I would repost another round of updating patch series and hope that would be merged. How do you think about this? Thanks, Lei -----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 21:55 To: David Woodhouse Cc: Haojian Zhuang; Lei Wen; Axel Lin; linux-kernel; linux-mtd@lists.infradead.org Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 On Mon, Aug 16, 2010 at 9:05 PM, David Woodhouse <dwmw2@infradead.org> wrote: > On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote: >> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote: >> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html >> > >> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. >> > >> > By the way, David, what's the result of review on these patches? We already posted for several times. >> > >> >> I've actually reviewed some of the patches and gave my Ack. For those >> patches, I think they can be merged early. >> >> And overall, they look good. Yet 29 patch in a whole is still a bit too >> much, would be good to see them logically be separated into several >> patch series. > > You had some criticism of patch #1 in the sequence, and some questions. > So they need to be addressed. Lei, could you please come up with an updated patch? > I didn't look much harder than that, iirc... although looking back now > it seems that the rest of your responses to the sequence were largely > positive. > > Are you happy with the first patch, and if so shall I go ahead and > import the whole sequence with your Acked-By:? > I'm generally OK, but still think it would be good to have another around of review before they can be merged.
2010/8/16 Lei Wen <leiwen@marvell.com>: > Eric, > The first patch is a bit of fundamental. I'm afraid that modify it would bring changes to all latter patches in this series... > > So I think I would repost another round of updating patch series and hope that would be merged. How do you think about this? > Please separate the patches into several patch series. (PS: I'll possibly talk with you on this tomorrow F2F)
I may not have time from 10am to 11am. Except that, any time is ok for me. :-) Best regards, Lei -----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 22:17 To: Lei Wen Cc: David Woodhouse; Haojian Zhuang; Axel Lin; linux-kernel; linux-mtd@lists.infradead.org Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 2010/8/16 Lei Wen <leiwen@marvell.com>: > Eric, > The first patch is a bit of fundamental. I'm afraid that modify it would bring changes to all latter patches in this series... > > So I think I would repost another round of updating patch series and hope that would be merged. How do you think about this? > Please separate the patches into several patch series. (PS: I'll possibly talk with you on this tomorrow F2F)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index 4d89f37..47c0442 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -227,9 +227,21 @@ static struct pxa3xx_nand_flash samsung512MbX16 = { .chip_id = 0x46ec, }; +static struct pxa3xx_nand_timing samsung2GbX8_timing = { + .tCH = 5, + .tCS = 20, + .tWH = 10, + .tWP = 12, + .tRH = 10, + .tRP = 12, + .tR = 25000, + .tWHR = 60, + .tAR = 10, +}; + static struct pxa3xx_nand_flash samsung2GbX8 = { - .timing = &samsung512MbX16_timing, - .cmdset = &smallpage_cmdset, + .timing = &samsung2GbX8_timing, + .cmdset = &largepage_cmdset, .page_per_block = 64, .page_size = 2048, .flash_width = 8,
This patch adds timing settings for samsung2GbX8 and fixes the cmdset settings. samsung2GbX8 is large page. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mtd/nand/pxa3xx_nand.c | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-)