Patchwork target-i386: svm: Fix MSRPM check

login
register
mail settings
Submitter Adam Lackorzynski
Date Aug. 15, 2010, 1:58 p.m.
Message ID <20100815135832.GA5355@os.inf.tu-dresden.de>
Download mbox | patch
Permalink /patch/61745/
State New
Headers show

Comments

Adam Lackorzynski - Aug. 15, 2010, 1:58 p.m.
Correct the calculation of the offset in the msrpm
for the MSR range 0 - 0x1fff.

Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
---
 target-i386/op_helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Anthony Liguori - Aug. 22, 2010, 9:29 p.m.
On 08/15/2010 08:58 AM, Adam Lackorzynski wrote:
> Correct the calculation of the offset in the msrpm
> for the MSR range 0 - 0x1fff.
>
> Signed-off-by: Adam Lackorzynski<adam@os.inf.tu-dresden.de>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   target-i386/op_helper.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index c50e818..ec6b3e9 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -5237,7 +5237,7 @@ void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
>               switch((uint32_t)ECX) {
>               case 0 ... 0x1fff:
>                   t0 = (ECX * 2) % 8;
> -                t1 = ECX / 8;
> +                t1 = (ECX * 2) / 8;
>                   break;
>               case 0xc0000000 ... 0xc0001fff:
>                   t0 = (8192 + ECX - 0xc0000000) * 2;
>

Patch

diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c50e818..ec6b3e9 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -5237,7 +5237,7 @@  void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
             switch((uint32_t)ECX) {
             case 0 ... 0x1fff:
                 t0 = (ECX * 2) % 8;
-                t1 = ECX / 8;
+                t1 = (ECX * 2) / 8;
                 break;
             case 0xc0000000 ... 0xc0001fff:
                 t0 = (8192 + ECX - 0xc0000000) * 2;