| Message ID | CAPmmg8v-6J=yoCP2iiKVcVsWOVforD5pnaf6BwBsPj7jOfZ0Ow@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | John Crispin |
| Headers | show |
On 01/05/2016 23:36:05 CEST, Saverio Proto wrote: > This patch is also available here: > https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e > > commit 0281382bcaa139f0d1d3b589797af4c434747f3e > Author: Saverio Proto <zioproto@gmail.com> > Date: Sun May 1 23:14:19 2016 +0200 > > ramips: Fix IPv6 neighbor discovery on RT5350 > > IPv6 neighbor discovery needs working IPv6 multicast. The register FCT2 > should be set to 0x2500C to let through "unknown IPv6 multicast" to > all ports. This is based on datasheet information: > https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf > > Signed-off-by: Saverio Proto <zioproto@gmail.com> Reviewed-by: Vittorio Gambaletta <openwrt@vittgam.net> > > diff --git a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c > b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c > index ef13d23..d09eaf3 100644 > --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c > +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c > @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { > static struct rt305x_esw_platform_data rt3050_esw_data = { > /* All ports are LAN ports. */ > .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, > - .reg_initval_fct2 = 0x00d6500c, > + .reg_initval_fct2 = 0x0002500c, > /* > * ext phy base addr 31, enable port 5 polling, rx/tx clock skew 1, > * turbo mii off, rgmi 3.3v off > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Actually there's a problem with this patch: the tabs have been converted to spaces by your mailer, so it does not apply directly... The patch on GitHub is fine by the way. Cheers, Vittorio On 01/05/2016 23:59:27 CEST, Vittorio G (VittGam) wrote: > On 01/05/2016 23:36:05 CEST, Saverio Proto wrote: >> This patch is also available here: >> https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e >> >> commit 0281382bcaa139f0d1d3b589797af4c434747f3e >> Author: Saverio Proto <zioproto@gmail.com> >> Date: Sun May 1 23:14:19 2016 +0200 >> >> ramips: Fix IPv6 neighbor discovery on RT5350 >> >> IPv6 neighbor discovery needs working IPv6 multicast. The register FCT2 >> should be set to 0x2500C to let through "unknown IPv6 multicast" to >> all ports. This is based on datasheet information: >> https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf >> >> Signed-off-by: Saverio Proto <zioproto@gmail.com> > > Reviewed-by: Vittorio Gambaletta <openwrt@vittgam.net> > >> >> diff --git a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >> b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >> index ef13d23..d09eaf3 100644 >> --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >> +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >> @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { >> static struct rt305x_esw_platform_data rt3050_esw_data = { >> /* All ports are LAN ports. */ >> .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, >> - .reg_initval_fct2 = 0x00d6500c, >> + .reg_initval_fct2 = 0x0002500c, >> /* >> * ext phy base addr 31, enable port 5 polling, rx/tx clock skew 1, >> * turbo mii off, rgmi 3.3v off >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
On 02/05/2016 09:55, Vittorio G (VittGam) wrote: > Actually there's a problem with this patch: the tabs have been converted > to spaces by your mailer, so it does not apply directly... > > The patch on GitHub is fine by the way. > > Cheers, > Vittorio you seem to have sent the same patch which does not look whitespace broken. i'll use that one instead. John > > On 01/05/2016 23:59:27 CEST, Vittorio G (VittGam) wrote: >> On 01/05/2016 23:36:05 CEST, Saverio Proto wrote: >>> This patch is also available here: >>> https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e >>> >>> >>> commit 0281382bcaa139f0d1d3b589797af4c434747f3e >>> Author: Saverio Proto <zioproto@gmail.com> >>> Date: Sun May 1 23:14:19 2016 +0200 >>> >>> ramips: Fix IPv6 neighbor discovery on RT5350 >>> >>> IPv6 neighbor discovery needs working IPv6 multicast. The >>> register FCT2 >>> should be set to 0x2500C to let through "unknown IPv6 multicast" to >>> all ports. This is based on datasheet information: >>> https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf >>> >>> Signed-off-by: Saverio Proto <zioproto@gmail.com> >> >> Reviewed-by: Vittorio Gambaletta <openwrt@vittgam.net> >> >>> >>> diff --git >>> a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>> b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>> index ef13d23..d09eaf3 100644 >>> --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>> +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>> @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { >>> static struct rt305x_esw_platform_data rt3050_esw_data = { >>> /* All ports are LAN ports. */ >>> .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, >>> - .reg_initval_fct2 = 0x00d6500c, >>> + .reg_initval_fct2 = 0x0002500c, >>> /* >>> * ext phy base addr 31, enable port 5 polling, rx/tx clock >>> skew 1, >>> * turbo mii off, rgmi 3.3v off >>> _______________________________________________ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
On 02/05/2016 10:06:49 CEST, John Crispin wrote: > On 02/05/2016 09:55, Vittorio G (VittGam) wrote: >> Actually there's a problem with this patch: the tabs have been converted >> to spaces by your mailer, so it does not apply directly... >> >> The patch on GitHub is fine by the way. >> >> Cheers, >> Vittorio > > you seem to have sent the same patch which does not look whitespace > broken. i'll use that one instead. My patch is not for CC... it's for trunk which uses the newer rt305x driver. Cheers, Vittorio > > John > >> >> On 01/05/2016 23:59:27 CEST, Vittorio G (VittGam) wrote: >>> On 01/05/2016 23:36:05 CEST, Saverio Proto wrote: >>>> This patch is also available here: >>>> https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e >>>> >>>> >>>> commit 0281382bcaa139f0d1d3b589797af4c434747f3e >>>> Author: Saverio Proto <zioproto@gmail.com> >>>> Date: Sun May 1 23:14:19 2016 +0200 >>>> >>>> ramips: Fix IPv6 neighbor discovery on RT5350 >>>> >>>> IPv6 neighbor discovery needs working IPv6 multicast. The >>>> register FCT2 >>>> should be set to 0x2500C to let through "unknown IPv6 multicast" to >>>> all ports. This is based on datasheet information: >>>> https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf >>>> >>>> Signed-off-by: Saverio Proto <zioproto@gmail.com> >>> >>> Reviewed-by: Vittorio Gambaletta <openwrt@vittgam.net> >>> >>>> >>>> diff --git >>>> a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>> b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>> index ef13d23..d09eaf3 100644 >>>> --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>> +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>> @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { >>>> static struct rt305x_esw_platform_data rt3050_esw_data = { >>>> /* All ports are LAN ports. */ >>>> .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, >>>> - .reg_initval_fct2 = 0x00d6500c, >>>> + .reg_initval_fct2 = 0x0002500c, >>>> /* >>>> * ext phy base addr 31, enable port 5 polling, rx/tx clock >>>> skew 1, >>>> * turbo mii off, rgmi 3.3v off >>>> _______________________________________________ >>>> openwrt-devel mailing list >>>> openwrt-devel@lists.openwrt.org >>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >>> _______________________________________________ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
I attach the patch in this email so should be without whitespace problem. thank you Saverio 2016-05-02 10:09 GMT+02:00 Vittorio G (VittGam) <openwrt@vittgam.net>: > On 02/05/2016 10:06:49 CEST, John Crispin wrote: >> >> On 02/05/2016 09:55, Vittorio G (VittGam) wrote: >>> >>> Actually there's a problem with this patch: the tabs have been converted >>> to spaces by your mailer, so it does not apply directly... >>> >>> The patch on GitHub is fine by the way. >>> >>> Cheers, >>> Vittorio >> >> >> you seem to have sent the same patch which does not look whitespace >> broken. i'll use that one instead. > > > My patch is not for CC... it's for trunk which uses the newer rt305x driver. > > Cheers, > Vittorio > > >> >> John >> >>> >>> On 01/05/2016 23:59:27 CEST, Vittorio G (VittGam) wrote: >>>> >>>> On 01/05/2016 23:36:05 CEST, Saverio Proto wrote: >>>>> >>>>> This patch is also available here: >>>>> >>>>> https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e >>>>> >>>>> >>>>> commit 0281382bcaa139f0d1d3b589797af4c434747f3e >>>>> Author: Saverio Proto <zioproto@gmail.com> >>>>> Date: Sun May 1 23:14:19 2016 +0200 >>>>> >>>>> ramips: Fix IPv6 neighbor discovery on RT5350 >>>>> >>>>> IPv6 neighbor discovery needs working IPv6 multicast. The >>>>> register FCT2 >>>>> should be set to 0x2500C to let through "unknown IPv6 multicast" to >>>>> all ports. This is based on datasheet information: >>>>> https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf >>>>> >>>>> Signed-off-by: Saverio Proto <zioproto@gmail.com> >>>> >>>> >>>> Reviewed-by: Vittorio Gambaletta <openwrt@vittgam.net> >>>> >>>>> >>>>> diff --git >>>>> a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>>> b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>>> index ef13d23..d09eaf3 100644 >>>>> --- >>>>> a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>>> +++ >>>>> b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c >>>>> @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { >>>>> static struct rt305x_esw_platform_data rt3050_esw_data = { >>>>> /* All ports are LAN ports. */ >>>>> .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, >>>>> - .reg_initval_fct2 = 0x00d6500c, >>>>> + .reg_initval_fct2 = 0x0002500c, >>>>> /* >>>>> * ext phy base addr 31, enable port 5 polling, rx/tx clock >>>>> skew 1, >>>>> * turbo mii off, rgmi 3.3v off >>>>> _______________________________________________ >>>>> openwrt-devel mailing list >>>>> openwrt-devel@lists.openwrt.org >>>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >>>> >>>> _______________________________________________ >>>> openwrt-devel mailing list >>>> openwrt-devel@lists.openwrt.org >>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >>> >>> _______________________________________________ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
diff --git a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c index ef13d23..d09eaf3 100644 --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c @@ -1360,7 +1360,7 @@ static const struct switch_dev_ops esw_ops = { static struct rt305x_esw_platform_data rt3050_esw_data = { /* All ports are LAN ports. */ .vlan_config = RT305X_ESW_VLAN_CONFIG_NONE, - .reg_initval_fct2 = 0x00d6500c, + .reg_initval_fct2 = 0x0002500c, /* * ext phy base addr 31, enable port 5 polling, rx/tx clock skew 1, * turbo mii off, rgmi 3.3v off
This patch is also available here: https://github.com/zioproto/openwrt15051-batman/commit/0281382bcaa139f0d1d3b589797af4c434747f3e commit 0281382bcaa139f0d1d3b589797af4c434747f3e Author: Saverio Proto <zioproto@gmail.com> Date: Sun May 1 23:14:19 2016 +0200 ramips: Fix IPv6 neighbor discovery on RT5350 IPv6 neighbor discovery needs working IPv6 multicast. The register FCT2 should be set to 0x2500C to let through "unknown IPv6 multicast" to all ports. This is based on datasheet information: https://cdn.sparkfun.com/datasheets/Wireless/WiFi/RT5350.pdf Signed-off-by: Saverio Proto <zioproto@gmail.com>