From patchwork Tue Oct 28 22:55:44 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Harrison X-Patchwork-Id: 6172 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9792EDDE1A for ; Wed, 29 Oct 2008 09:55:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbYJ1Wzu (ORCPT ); Tue, 28 Oct 2008 18:55:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752651AbYJ1Wzt (ORCPT ); Tue, 28 Oct 2008 18:55:49 -0400 Received: from rv-out-0506.google.com ([209.85.198.230]:22615 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752476AbYJ1Wzt (ORCPT ); Tue, 28 Oct 2008 18:55:49 -0400 Received: by rv-out-0506.google.com with SMTP id k40so2967241rvb.1 for ; Tue, 28 Oct 2008 15:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=t5tFdo9wgGxxQgHYK26mtqF9Yb5hcHvGNdtivxfz4pU=; b=kRzRbBC0dpsR57/ukYmlnYxct1qQyiaJitS4FoluukHzV9XWZEkvk3wCeaQsQ0AxmP CruJJwZEdj7PZ1lL6QVdm8OP51gfiAiQTGdyxJth6M9m47EprNqWNs3zIPScbUWqF4Z2 G/16vtQva/oWDVu++HFwWFX2Dc2ZuWEuJGUVM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=wcjvhbU6R4Gyc+zE0OSEjvktMfSoN7bcgpLYmwZ4j+PGW7XomDBIpHfZXIm8dHdxOO tk924MzRr4B2R3zXWLOp5uzsK4mqhi8+tMkuWnLqXQK0gaeIG2+KbITsRhlFfDoe8VNF wQv5nARVzNjkq5uTx2iVVf/9pNTrYWU0ycndc= Received: by 10.142.142.14 with SMTP id p14mr3656441wfd.114.1225234548119; Tue, 28 Oct 2008 15:55:48 -0700 (PDT) Received: from ?192.168.101.45? ([216.251.156.242]) by mx.google.com with ESMTPS id 20sm4905839wfi.11.2008.10.28.15.55.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 28 Oct 2008 15:55:47 -0700 (PDT) Subject: [PATCH] uwb: use the %pM formatting specifier in eda.c From: Harvey Harrison To: David Miller Cc: Joe Perches , linux-netdev Date: Tue, 28 Oct 2008 15:55:44 -0700 Message-Id: <1225234544.11483.65.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Harvey Harrison --- drivers/uwb/wlp/eda.c | 38 +++++++++----------------------------- 1 files changed, 9 insertions(+), 29 deletions(-) diff --git a/drivers/uwb/wlp/eda.c b/drivers/uwb/wlp/eda.c index cdfe8df..10985fa 100644 --- a/drivers/uwb/wlp/eda.c +++ b/drivers/uwb/wlp/eda.c @@ -313,12 +313,9 @@ int wlp_eda_for_virtual(struct wlp_eda *eda, list_for_each_entry(itr, &eda->cache, list_node) { if (!memcmp(itr->virt_addr, virt_addr, sizeof(itr->virt_addr))) { - d_printf(6, dev, "EDA: looking for " - "%02x:%02x:%02x:%02x:%02x:%02x hit %02x:%02x " + d_printf(6, dev, "EDA: looking for %pM hit %02x:%02x " "wss %p tag 0x%02x state %u\n", - virt_addr[0], virt_addr[1], - virt_addr[2], virt_addr[3], - virt_addr[4], virt_addr[5], + virt_addr, itr->dev_addr.data[1], itr->dev_addr.data[0], itr->wss, itr->tag, itr->state); @@ -327,24 +324,13 @@ int wlp_eda_for_virtual(struct wlp_eda *eda, found = 1; break; } else - d_printf(6, dev, "EDA: looking for " - "%02x:%02x:%02x:%02x:%02x:%02x " - "against " - "%02x:%02x:%02x:%02x:%02x:%02x miss\n", - virt_addr[0], virt_addr[1], - virt_addr[2], virt_addr[3], - virt_addr[4], virt_addr[5], - itr->virt_addr[0], itr->virt_addr[1], - itr->virt_addr[2], itr->virt_addr[3], - itr->virt_addr[4], itr->virt_addr[5]); + d_printf(6, dev, "EDA: looking for %pM against %pM miss\n", + virt_addr, itr->virt_addr); } if (!found) { if (printk_ratelimit()) - dev_err(dev, "EDA: Eth addr %02x:%02x:%02x" - ":%02x:%02x:%02x not found.\n", - virt_addr[0], virt_addr[1], - virt_addr[2], virt_addr[3], - virt_addr[4], virt_addr[5]); + dev_err(dev, "EDA: Eth addr %pM not found.\n", + virt_addr); result = -ENODEV; } spin_unlock_irqrestore(&eda->lock, flags); @@ -380,19 +366,13 @@ ssize_t wlp_eda_show(struct wlp *wlp, char *buf) "tag state virt_addr\n"); list_for_each_entry(entry, &eda->cache, list_node) { result += scnprintf(buf + result, PAGE_SIZE - result, - "%02x:%02x:%02x:%02x:%02x:%02x %02x:%02x " - "%p 0x%02x %s " - "%02x:%02x:%02x:%02x:%02x:%02x\n", - entry->eth_addr[0], entry->eth_addr[1], - entry->eth_addr[2], entry->eth_addr[3], - entry->eth_addr[4], entry->eth_addr[5], + "%pM %02x:%02x %p 0x%02x %s %pM\n", + entry->eth_addr, entry->dev_addr.data[1], entry->dev_addr.data[0], entry->wss, entry->tag, wlp_wss_connect_state_str(entry->state), - entry->virt_addr[0], entry->virt_addr[1], - entry->virt_addr[2], entry->virt_addr[3], - entry->virt_addr[4], entry->virt_addr[5]); + entry->virt_addr); if (result >= PAGE_SIZE) break; }