Message ID | 1461964613-4872-6-git-send-email-edumazet@google.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, Apr 29, 2016 at 02:16:51PM -0700, Eric Dumazet wrote: > sctp_inq_push() will soon be called without BH being blocked > when generic socket code flushes the socket backlog. > > It is very possible SCTP can be converted to not rely on BH, > but this needs to be done by SCTP experts. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Thanks > --- > net/sctp/inqueue.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c > index b335ffcef0b9..9d87bba0ff1d 100644 > --- a/net/sctp/inqueue.c > +++ b/net/sctp/inqueue.c > @@ -89,10 +89,12 @@ void sctp_inq_push(struct sctp_inq *q, struct sctp_chunk *chunk) > * Eventually, we should clean up inqueue to not rely > * on the BH related data structures. > */ > + local_bh_disable(); > list_add_tail(&chunk->list, &q->in_chunk_list); > if (chunk->asoc) > chunk->asoc->stats.ipackets++; > q->immediate.func(&q->immediate); > + local_bh_enable(); > } > > /* Peek at the next chunk on the inqeue. */ > -- > 2.8.0.rc3.226.g39d4020 >
diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c index b335ffcef0b9..9d87bba0ff1d 100644 --- a/net/sctp/inqueue.c +++ b/net/sctp/inqueue.c @@ -89,10 +89,12 @@ void sctp_inq_push(struct sctp_inq *q, struct sctp_chunk *chunk) * Eventually, we should clean up inqueue to not rely * on the BH related data structures. */ + local_bh_disable(); list_add_tail(&chunk->list, &q->in_chunk_list); if (chunk->asoc) chunk->asoc->stats.ipackets++; q->immediate.func(&q->immediate); + local_bh_enable(); } /* Peek at the next chunk on the inqeue. */
sctp_inq_push() will soon be called without BH being blocked when generic socket code flushes the socket backlog. It is very possible SCTP can be converted to not rely on BH, but this needs to be done by SCTP experts. Signed-off-by: Eric Dumazet <edumazet@google.com> --- net/sctp/inqueue.c | 2 ++ 1 file changed, 2 insertions(+)