From patchwork Fri Aug 13 10:30:02 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Uros Bizjak <ubizjak@gmail.com>
X-Patchwork-Id: 61678
Return-Path: 
 <gcc-patches-return-270447-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id 120B3B6EEC
	for <incoming@patchwork.ozlabs.org>;
	Fri, 13 Aug 2010 20:30:15 +1000 (EST)
Received: (qmail 13949 invoked by alias); 13 Aug 2010 10:30:10 -0000
Received: (qmail 13849 invoked by uid 22791); 13 Aug 2010 10:30:09 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL, BAYES_00,
	DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM,
	RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f175.google.com (HELO mail-qy0-f175.google.com)
	(209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with
	ESMTP; Fri, 13 Aug 2010 10:30:04 +0000
Received: by qyk11 with SMTP id 11so687958qyk.20 for
	<gcc-patches@gcc.gnu.org>; Fri, 13 Aug 2010 03:30:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.112.204 with SMTP id x12mr861200qap.170.1281695402389;
	Fri, 13 Aug 2010 03:30:02 -0700 (PDT)
Received: by 10.229.182.18 with HTTP; Fri, 13 Aug 2010 03:30:02 -0700 (PDT)
Date: Fri, 13 Aug 2010 12:30:02 +0200
Message-ID: <AANLkTi=0Qya=AmQ8040PAOpdOyaJ1Q-4z4qnJF2gc70-@mail.gmail.com>
Subject: Re: [vect] Ask for review and approving the patch about vect and
	loongson
From: Uros Bizjak <ubizjak@gmail.com>
To: Mingjie Xing <mingjie.xing@gmail.com>
Cc: rdsandiford@googlemail.com, richard.guenther@gmail.com,
	gcc-patches@gcc.gnu.org
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

Hello!

> Mingjie Xing  <mingjie.xing@gmail.com>
>
> gcc/ChangeLog
>  * loongson.md: Change define_insn "loongson_pmull<V_suffix>" to "mul<mode>3".
>  * mips.c: Add "#define CODE_FOR_loongson_pmullh CODE_FOR_mulv4hi3".
>
> testsuite/ChangeLog
>  * fast-math-vect-reduc-8.c: Move dg-require-effective-target after dg-do.
>  * vect.exp: Run the vect testsuite when the target is loongson*
>  * target-supports.exp: Check loongson target in vector specific attributes.


There are various copies of vect.exp scattered in the testsuite:

$ find . -name vect.exp
./gcc.dg/vect/vect.exp
./gfortran.dg/vect/vect.exp
./g++.dg/vect/vect.exp

You will need to change them all. Bonus points if you merge all these
files into globally accessible support library.

Uros.

Index: testsuite/gcc.dg/vect/vect.exp
===================================================================
--- testsuite/gcc.dg/vect/vect.exp	(revision 163219)
+++ testsuite/gcc.dg/vect/vect.exp	(working copy)
@@ -74,9 +74,12 @@ if  [istarget "powerpc-*paired*"]  {
 	set dg-do-what-default compile
     }
 } elseif { [istarget "mips*-*-*"]
-	   && [check_effective_target_mpaired_single]
-	   && [check_effective_target_nomips16] } {
-    lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+           && ([check_effective_target_mpaired_single]
+               || [check_effective_target_mips_loongson])
+           && [check_effective_target_nomips16] } {
+    if { [check_effective_target_mpaired_single] } {
+      lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    }
     set dg-do-what-default run
 } elseif [istarget "sparc*-*-*"] {
     lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"