Patchwork [-next] ubi: fix kconfig unmet dependency

login
register
mail settings
Submitter Randy Dunlap
Date Aug. 12, 2010, 7:10 p.m.
Message ID <20100812121059.e1d40380.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/61643/
State Accepted
Commit 1deacd7a1d4bb22f812908c34e3254de76e4faa8
Headers show

Comments

Randy Dunlap - Aug. 12, 2010, 7:10 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT && DEBUG_KERNEL || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Artem Bityutskiy <dedekind1@gmail.com>
Cc:	linux-mtd@lists.infradead.org
---
 drivers/mtd/ubi/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This builds cleanly.  Will it execute OK?
or we can make MTD_UBI_DEBUG depend on KALLSYMS_ALL.
Artem Bityutskiy - Aug. 30, 2010, 7:49 a.m.
On Thu, 2010-08-12 at 12:10 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT && DEBUG_KERNEL || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Artem Bityutskiy <dedekind1@gmail.com>
> Cc:	linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/ubi/Kconfig.debug |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pushed to the ubi-2.6.git tree, thanks! I'll send it to 2.6.36 soon.

Patch

--- linux-next-20100810.orig/drivers/mtd/ubi/Kconfig.debug
+++ linux-next-20100810/drivers/mtd/ubi/Kconfig.debug
@@ -6,7 +6,7 @@  config MTD_UBI_DEBUG
 	depends on SYSFS
 	depends on MTD_UBI
 	select DEBUG_FS
-	select KALLSYMS_ALL
+	select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL
 	help
 	  This option enables UBI debugging.